diff options
author | Jiayu Liu <jiayu@hey.com> | 2022-09-19 13:17:05 +0800 |
---|---|---|
committer | Jens Geyer <jensg@apache.org> | 2022-09-19 19:23:47 +0200 |
commit | 60655d2de79e973b89fab52af82f9628d4843b0f (patch) | |
tree | 0269743d2c9b3fa513ecee7fa1be1a6167ed838e | |
parent | 4d493e867b349f3475203ef9848353b315203c51 (diff) | |
download | thrift-0.17.0.tar.gz |
fix pmd main for java0.17.0
3 files changed, 13 insertions, 18 deletions
diff --git a/lib/java/src/main/java/org/apache/thrift/TNonblockingMultiFetchClient.java b/lib/java/src/main/java/org/apache/thrift/TNonblockingMultiFetchClient.java index 034cc8599..ffe4fa701 100644 --- a/lib/java/src/main/java/org/apache/thrift/TNonblockingMultiFetchClient.java +++ b/lib/java/src/main/java/org/apache/thrift/TNonblockingMultiFetchClient.java @@ -280,16 +280,14 @@ public class TNonblockingMultiFetchClient { } } - if (selKey.isValid() && selKey.isWritable()) { - if (sendBuf[index].hasRemaining()) { - // if this socket throws an exception, print error msg and - // skip it. - try { - SocketChannel sChannel = (SocketChannel) selKey.channel(); - sChannel.write(sendBuf[index]); - } catch (Exception e) { - LOGGER.error("Socket {} writes to server {} error", index, servers.get(index), e); - } + if (selKey.isValid() && selKey.isWritable() && sendBuf[index].hasRemaining()) { + // if this socket throws an exception, print error msg and + // skip it. + try { + SocketChannel sChannel = (SocketChannel) selKey.channel(); + sChannel.write(sendBuf[index]); + } catch (Exception e) { + LOGGER.error("Socket {} writes to server {} error", index, servers.get(index), e); } } diff --git a/lib/java/src/main/java/org/apache/thrift/server/AbstractNonblockingServer.java b/lib/java/src/main/java/org/apache/thrift/server/AbstractNonblockingServer.java index 44341d909..01b15e841 100644 --- a/lib/java/src/main/java/org/apache/thrift/server/AbstractNonblockingServer.java +++ b/lib/java/src/main/java/org/apache/thrift/server/AbstractNonblockingServer.java @@ -190,10 +190,8 @@ public abstract class AbstractNonblockingServer extends TServer { } // if the buffer's frame read is complete, invoke the method. - if (buffer.isFrameFullyRead()) { - if (!requestInvoke(buffer)) { - cleanupSelectionKey(key); - } + if (buffer.isFrameFullyRead() && !requestInvoke(buffer)) { + cleanupSelectionKey(key); } } diff --git a/lib/java/src/main/java/org/apache/thrift/transport/TFileTransport.java b/lib/java/src/main/java/org/apache/thrift/transport/TFileTransport.java index 713d52103..b06727249 100644 --- a/lib/java/src/main/java/org/apache/thrift/transport/TFileTransport.java +++ b/lib/java/src/main/java/org/apache/thrift/transport/TFileTransport.java @@ -447,12 +447,11 @@ public class TFileTransport extends TTransport { if (!isOpen()) throw new TTransportException(TTransportException.NOT_OPEN, "Must open before reading"); - if (currentEvent_.getRemaining() == 0) { - if (!readEvent()) return (0); + if (currentEvent_.getRemaining() == 0 && !readEvent()) { + return 0; } - int nread = currentEvent_.emit(buf, off, len); - return nread; + return currentEvent_.emit(buf, off, len); } public int getNumChunks() throws TTransportException { |