summaryrefslogtreecommitdiff
path: root/telepathy-logger/text-event.c
Commit message (Collapse)AuthorAgeFilesLines
* text-event: chain up disposeGuillaume Desmottes2013-09-271-0/+2
|
* Disable single include of telepathy-glib headersXavier Claessens2012-07-031-1/+1
|
* Fix introspection warningsJasper St. Pierre2012-05-281-9/+9
| | | | | | https://bugs.freedesktop.org/show_bug.cgi?id=50361 Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
* Improve GObject introspection anotationNicolas Dufresne2011-10-311-1/+2
|
* Use gint64 for timestamps (not guint64)David Laban2011-05-261-6/+6
|
* Add edit-timestamp, and remove original-timestampDavid Laban2011-05-261-14/+14
| | | | | | | | | log-store-xml: * store/save edit-timestamp rather than original-timestamp * Also don't let the edit timestamp override the timestamp for where messages are saved (as was the case for original-message). text-event: * s/original/edit/
* text-event: add original-timestamp propertyDavid Laban2011-05-241-0/+31
|
* text-event: s/dup_supersedes/get_supersedes/David Laban2011-05-241-13/+5
| | | | | | Copying and freeing lists of events is a waste of time. Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
* fixup! tpl_text_event_{add,dup}_supersedesDavid Laban2011-05-191-12/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Review comments addressed: > g_list_free_full() is glib 2.28 while the configure.ac says we need 0.2.25.11. > We usually to a g_list_foreach(list, unref), g_list_free() so we don't have to > bump to very recent glib version. > > Also,I strongly prefer if you clear the queue structure, and not keep random > pointers around then using this boolean. Also, as NULL is a correct empty list, > you don't have to do any NULL check. > > > Patch: "tpl_text_event_{add,dup}_supersedes": > > add_supersedes() writes into a TplTextEvent, this is not allowed in the public > interface, move this function to text-event-private.h and prepend a _. > > > + for (l = old_event->priv->supersedes.head; l != NULL; l = l->next) > > + g_queue_push_tail (&self->priv->supersedes, g_object_ref (l->data)); > > Use g_list_next() instead of "l = l->next" for readability, don't worry it's a > macro, not a function call. > > > + for (l = self->priv->supersedes.tail; l != NULL; l = l->prev) > > + supersedes = g_list_prepend (supersedes, g_object_ref (l->data)); > > Use g_list_previous(). > Also, I realised that my annotation (transfer full) was incorrect: Since I ref the object that is passed in, I think (transfer none) is the correct annotation (since I create a new ref rather than stealing it off the caller). Correct me if I'm wrong again.
* tpl_text_event_{add,dup}_supersedesDavid Laban2011-05-171-0/+65
| | | | A list of TplTextEvent (intended to be in log order)
* TplTextEvent: add {message,supersedes}-token propertiesDavid Laban2011-05-171-1/+69
|
* Removed broken editor instructionNicolas Dufresne2011-03-251-1/+0
|
* Remove unused pending message ID from text eventNicolas Dufresne2011-03-151-91/+3
|
* Correctly implement event_equalNicolas Dufresne2011-03-151-0/+16
| | | | | The old implementation was relying on a hash that did not contain all the contain all the information.
* Doc fixNicolas Dufresne2011-02-231-1/+1
|
* Fix wrong max value for pending-msg-id propertyNicolas Dufresne2011-02-081-1/+1
|
* Renamed TplEventText into TplTextEventNicolas Dufresne2011-02-081-0/+326
This renames the subclass in a more natural and more traditional way as found in many other GObject based APIs.