Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Disable single include of telepathy-glib headers | Xavier Claessens | 2012-07-03 | 1 | -1/+1 |
| | |||||
* | Fix introspection warnings | Jasper St. Pierre | 2012-05-28 | 1 | -9/+9 |
| | | | | | | https://bugs.freedesktop.org/show_bug.cgi?id=50361 Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> | ||||
* | Improve GObject introspection anotation | Nicolas Dufresne | 2011-10-31 | 1 | -1/+2 |
| | |||||
* | Use gint64 for timestamps (not guint64) | David Laban | 2011-05-26 | 1 | -6/+6 |
| | |||||
* | Add edit-timestamp, and remove original-timestamp | David Laban | 2011-05-26 | 1 | -14/+14 |
| | | | | | | | | | log-store-xml: * store/save edit-timestamp rather than original-timestamp * Also don't let the edit timestamp override the timestamp for where messages are saved (as was the case for original-message). text-event: * s/original/edit/ | ||||
* | text-event: add original-timestamp property | David Laban | 2011-05-24 | 1 | -0/+31 |
| | |||||
* | text-event: s/dup_supersedes/get_supersedes/ | David Laban | 2011-05-24 | 1 | -13/+5 |
| | | | | | | Copying and freeing lists of events is a waste of time. Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.co.uk> | ||||
* | fixup! tpl_text_event_{add,dup}_supersedes | David Laban | 2011-05-19 | 1 | -12/+10 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Review comments addressed: > g_list_free_full() is glib 2.28 while the configure.ac says we need 0.2.25.11. > We usually to a g_list_foreach(list, unref), g_list_free() so we don't have to > bump to very recent glib version. > > Also,I strongly prefer if you clear the queue structure, and not keep random > pointers around then using this boolean. Also, as NULL is a correct empty list, > you don't have to do any NULL check. > > > Patch: "tpl_text_event_{add,dup}_supersedes": > > add_supersedes() writes into a TplTextEvent, this is not allowed in the public > interface, move this function to text-event-private.h and prepend a _. > > > + for (l = old_event->priv->supersedes.head; l != NULL; l = l->next) > > + g_queue_push_tail (&self->priv->supersedes, g_object_ref (l->data)); > > Use g_list_next() instead of "l = l->next" for readability, don't worry it's a > macro, not a function call. > > > + for (l = self->priv->supersedes.tail; l != NULL; l = l->prev) > > + supersedes = g_list_prepend (supersedes, g_object_ref (l->data)); > > Use g_list_previous(). > Also, I realised that my annotation (transfer full) was incorrect: Since I ref the object that is passed in, I think (transfer none) is the correct annotation (since I create a new ref rather than stealing it off the caller). Correct me if I'm wrong again. | ||||
* | tpl_text_event_{add,dup}_supersedes | David Laban | 2011-05-17 | 1 | -0/+65 |
| | | | | A list of TplTextEvent (intended to be in log order) | ||||
* | TplTextEvent: add {message,supersedes}-token properties | David Laban | 2011-05-17 | 1 | -1/+69 |
| | |||||
* | Removed broken editor instruction | Nicolas Dufresne | 2011-03-25 | 1 | -1/+0 |
| | |||||
* | Remove unused pending message ID from text event | Nicolas Dufresne | 2011-03-15 | 1 | -91/+3 |
| | |||||
* | Correctly implement event_equal | Nicolas Dufresne | 2011-03-15 | 1 | -0/+16 |
| | | | | | The old implementation was relying on a hash that did not contain all the contain all the information. | ||||
* | Doc fix | Nicolas Dufresne | 2011-02-23 | 1 | -1/+1 |
| | |||||
* | Fix wrong max value for pending-msg-id property | Nicolas Dufresne | 2011-02-08 | 1 | -1/+1 |
| | |||||
* | Renamed TplEventText into TplTextEvent | Nicolas Dufresne | 2011-02-08 | 1 | -0/+326 |
This renames the subclass in a more natural and more traditional way as found in many other GObject based APIs. |