summaryrefslogtreecommitdiff
path: root/print-hsrp.c
diff options
context:
space:
mode:
authorFrancois-Xavier Le Bail <devel.fx.lebail@orange.fr>2020-08-10 16:22:37 +0200
committerFrancois-Xavier Le Bail <devel.fx.lebail@orange.fr>2020-09-05 14:59:21 +0200
commit929e4be621ebdcede37865a5767a175f083f9138 (patch)
treebf6ecbc038696e66176b2d50e04e015767f23b3d /print-hsrp.c
parent54b5db3dde658894be730b15480f9b6e27b717a0 (diff)
downloadtcpdump-test-rc.tar.gz
Remove many (761) redundant ND_TCHECK_n() callstest-rc
ND_TCHECK_n(e), n in { 1, 2, 3, 4, 8 }. They are redundant because they are followed by a GET_.*_n(e) call, same n, same e, which do the bounds check. Remove unused 'trunc' labels and most associated codes. Update the outputs of some tests accordingly.
Diffstat (limited to 'print-hsrp.c')
-rw-r--r--print-hsrp.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/print-hsrp.c b/print-hsrp.c
index 8f0ab18c..7c7ad218 100644
--- a/print-hsrp.c
+++ b/print-hsrp.c
@@ -100,7 +100,6 @@ hsrp_print(netdissect_options *ndo, const u_char *bp, u_int len)
uint8_t version;
ndo->ndo_protocol = "hsrp";
- ND_TCHECK_1(hp->hsrp_version);
version = GET_U_1(hp->hsrp_version);
ND_PRINT("HSRPv%u", version);
if (version != 0)
@@ -110,12 +109,9 @@ hsrp_print(netdissect_options *ndo, const u_char *bp, u_int len)
ND_PRINT("%s ",
tok2strary(op_code_str, "unknown (%u)", GET_U_1(hp->hsrp_op_code)));
ND_PRINT("%u: ", len);
- ND_TCHECK_1(hp->hsrp_state);
ND_PRINT("state=%s ",
tok2str(states, "Unknown (%u)", GET_U_1(hp->hsrp_state)));
- ND_TCHECK_1(hp->hsrp_group);
ND_PRINT("group=%u ", GET_U_1(hp->hsrp_group));
- ND_TCHECK_1(hp->hsrp_reserved);
if (GET_U_1(hp->hsrp_reserved) != 0) {
ND_PRINT("[reserved=%u!] ", GET_U_1(hp->hsrp_reserved));
}