diff options
author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2021-04-08 10:57:40 +0200 |
---|---|---|
committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2021-04-08 20:21:50 +0200 |
commit | b1e1e5ac255285aac2a26467df3a7b934a3f2000 (patch) | |
tree | 1e9c150d5b452e5f840f54cfac013b99f15faa1d /test | |
parent | 68bb821e21d44e8dff86414fe0ae137ecdbc9934 (diff) | |
download | systemd-b1e1e5ac255285aac2a26467df3a7b934a3f2000.tar.gz |
TEST-17: make the test test
'! grep -v' does *not* test that there are no matching lines.
Instead, it checks that whether there are any non-matching lines.
And of course, for the test to fail, '! grep' cannot be part of
an expression with &&.
Diffstat (limited to 'test')
-rwxr-xr-x | test/units/testsuite-17.04.sh | 57 |
1 files changed, 24 insertions, 33 deletions
diff --git a/test/units/testsuite-17.04.sh b/test/units/testsuite-17.04.sh index 428aa81332..b33d47ef6d 100755 --- a/test/units/testsuite-17.04.sh +++ b/test/units/testsuite-17.04.sh @@ -4,12 +4,9 @@ set -o pipefail mkdir -p /run/udev/rules.d/ -! test -f /run/udev/tags/added/c1:3 && - ! test -f /run/udev/tags/changed/c1:3 && - udevadm info /dev/null | grep -q -v 'E: TAGS=.*:added:.*' && - udevadm info /dev/null | grep -q -v 'E: CURRENT_TAGS=.*:added:.*' && - udevadm info /dev/null | grep -q -v 'E: TAGS=.*:changed:.*' && - udevadm info /dev/null | grep -q -v 'E: CURRENT_TAGS=.*:changed:.*' +test ! -f /run/udev/tags/added/c1:3 +test ! -f /run/udev/tags/changed/c1:3 +udevadm info /dev/null | grep -E 'E: (TAGS|CURRENT_TAGS)=.*:(added|changed):' && exit 1 cat >/run/udev/rules.d/50-testsuite.rules <<EOF ACTION=="add", SUBSYSTEM=="mem", KERNEL=="null", TAG+="added" @@ -19,45 +16,39 @@ EOF udevadm control --reload udevadm trigger -c add /dev/null -while : ; do - test -f /run/udev/tags/added/c1:3 && - ! test -f /run/udev/tags/changed/c1:3 && - udevadm info /dev/null | grep -q 'E: TAGS=.*:added:.*' && - udevadm info /dev/null | grep -q 'E: CURRENT_TAGS=.*:added:.*' && - udevadm info /dev/null | grep -q -v 'E: TAGS=.*:changed:.*' && - udevadm info /dev/null | grep -q -v 'E: CURRENT_TAGS=.*:changed:.*' && - break - +while test ! -f /run/udev/tags/added/c1:3 || + test -f /run/udev/tags/changed/c1:3 || + ! udevadm info /dev/null | grep -q 'E: TAGS=.*:added:.*' || + ! udevadm info /dev/null | grep -q 'E: CURRENT_TAGS=.*:added:.*' || + udevadm info /dev/null | grep -q 'E: TAGS=.*:changed:.*' || + udevadm info /dev/null | grep -q 'E: CURRENT_TAGS=.*:changed:.*' +do sleep .5 done udevadm control --reload udevadm trigger -c change /dev/null -while : ; do - test -f /run/udev/tags/added/c1:3 && - test -f /run/udev/tags/changed/c1:3 && - udevadm info /dev/null | grep -q 'E: TAGS=.*:added:.*' && - udevadm info /dev/null | grep -q -v 'E: CURRENT_TAGS=.*:added:.*' && - udevadm info /dev/null | grep -q 'E: TAGS=.*:changed:.*' && - udevadm info /dev/null | grep -q 'E: CURRENT_TAGS=.*:changed:.*' && - break - +while test ! -f /run/udev/tags/added/c1:3 || + test ! -f /run/udev/tags/changed/c1:3 || + ! udevadm info /dev/null | grep -q 'E: TAGS=.*:added:.*' || + udevadm info /dev/null | grep -q 'E: CURRENT_TAGS=.*:added:.*' || + ! udevadm info /dev/null | grep -q 'E: TAGS=.*:changed:.*' || + ! udevadm info /dev/null | grep -q 'E: CURRENT_TAGS=.*:changed:.*' +do sleep .5 done udevadm control --reload udevadm trigger -c add /dev/null -while : ; do - test -f /run/udev/tags/added/c1:3 && - test -f /run/udev/tags/changed/c1:3 && - udevadm info /dev/null | grep -q 'E: TAGS=.*:added:.*' && - udevadm info /dev/null | grep -q 'E: CURRENT_TAGS=.*:added:.*' && - udevadm info /dev/null | grep -q 'E: TAGS=.*:changed:.*' && - udevadm info /dev/null | grep -q -v 'E: CURRENT_TAGS=.*:changed:.*' && - break - +while test ! -f /run/udev/tags/added/c1:3 || + test ! -f /run/udev/tags/changed/c1:3 || + ! udevadm info /dev/null | grep -q 'E: TAGS=.*:added:.*' || + ! udevadm info /dev/null | grep -q 'E: CURRENT_TAGS=.*:added:.*' || + ! udevadm info /dev/null | grep -q 'E: TAGS=.*:changed:.*' || + udevadm info /dev/null | grep -q 'E: CURRENT_TAGS=.*:changed:.*' +do sleep .5 done |