summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>2021-07-22 11:22:33 +0200
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>2021-07-24 11:46:23 +0200
commit6d825ab2d42d3219e49a192bf99f9c09134a0df4 (patch)
tree3411f53c879744b5e40ecdb60aed91fe9c7bd8cf /test
parent7d9ee15d0fc2af87481ee371b278dbe7e68165ef (diff)
downloadsystemd-6d825ab2d42d3219e49a192bf99f9c09134a0df4.tar.gz
rpm: use a helper script to actually invoke systemctl commands
Instead of embedding the commands to invoke directly in the macros, let's use a helper script as indirection. This has a couple of advantages: - the macro language is awkward, we need to suffix most commands by "|| :" and "\", which is easy to get wrong. In the new scheme, the macro becomes a single simple command. - in the script we can use normal syntax highlighting, shellcheck, etc. - it's also easier to test the invoked commands by invoking the helper manually. - most importantly, the logic is contained in the helper, i.e. we can update systemd rpm and everything uses the new helper. Before, we would have to rebuild all packages to update the macro definition. This raises the question whether it makes sense to use the lua scriptlets when the real work is done in a bash script. I think it's OK: we still have the efficient lua scripts that do the short scripts, and we use a single shared implementation in bash to do the more complex stuff. The meson version is raised to 0.47 because that's needed for install_mode. We were planning to raise the required version anyway…
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions