diff options
| author | Yu Watanabe <watanabe.yu+github@gmail.com> | 2021-06-15 00:51:33 +0900 |
|---|---|---|
| committer | Jan Macku <jamacku@redhat.com> | 2021-07-28 13:00:36 +0200 |
| commit | eaab8d57d9db0d98d7e618ba634983c34cdb9c06 (patch) | |
| tree | dd7f784f070a0f499c43e2517ed8c6b1a135dbcc | |
| parent | 3e7e54c63236c65aa01bb332fd5135a13e51b992 (diff) | |
| download | systemd-eaab8d57d9db0d98d7e618ba634983c34cdb9c06.tar.gz | |
sd-event: use CMP() macro
(cherry picked from commit 06e131477d82b83c5d516e66d6e413affd7c774a)
Related: #1984406
| -rw-r--r-- | src/libsystemd/sd-event/sd-event.c | 37 |
1 files changed, 17 insertions, 20 deletions
diff --git a/src/libsystemd/sd-event/sd-event.c b/src/libsystemd/sd-event/sd-event.c index 2b0b76aa1c..6a20b658e4 100644 --- a/src/libsystemd/sd-event/sd-event.c +++ b/src/libsystemd/sd-event/sd-event.c @@ -358,10 +358,9 @@ static int pending_prioq_compare(const void *a, const void *b) { assert(y->pending); /* Enabled ones first */ - if (x->enabled != SD_EVENT_OFF && y->enabled == SD_EVENT_OFF) - return -1; - if (x->enabled == SD_EVENT_OFF && y->enabled != SD_EVENT_OFF) - return 1; + r = CMP(x->enabled == SD_EVENT_OFF, y->enabled == SD_EVENT_OFF); + if (r != 0) + return r; /* Non rate-limited ones first. */ r = CMP(!!x->ratelimited, !!y->ratelimited); @@ -385,10 +384,9 @@ static int prepare_prioq_compare(const void *a, const void *b) { assert(y->prepare); /* Enabled ones first */ - if (x->enabled != SD_EVENT_OFF && y->enabled == SD_EVENT_OFF) - return -1; - if (x->enabled == SD_EVENT_OFF && y->enabled != SD_EVENT_OFF) - return 1; + r = CMP(x->enabled == SD_EVENT_OFF, y->enabled == SD_EVENT_OFF); + if (r != 0) + return r; /* Non rate-limited ones first. */ r = CMP(!!x->ratelimited, !!y->ratelimited); @@ -455,18 +453,17 @@ static bool event_source_timer_candidate(const sd_event_source *s) { static int time_prioq_compare(const void *a, const void *b, usec_t (*time_func)(const sd_event_source *s)) { const sd_event_source *x = a, *y = b; + int r; /* Enabled ones first */ - if (x->enabled != SD_EVENT_OFF && y->enabled == SD_EVENT_OFF) - return -1; - if (x->enabled == SD_EVENT_OFF && y->enabled != SD_EVENT_OFF) - return 1; + r = CMP(x->enabled == SD_EVENT_OFF, y->enabled == SD_EVENT_OFF); + if (r != 0) + return r; /* Order "non-pending OR ratelimited" before "pending AND not-ratelimited" */ - if (event_source_timer_candidate(x) && !event_source_timer_candidate(y)) - return -1; - if (!event_source_timer_candidate(x) && event_source_timer_candidate(y)) - return 1; + r = CMP(!event_source_timer_candidate(x), !event_source_timer_candidate(y)); + if (r != 0) + return r; /* Order by time */ return CMP(time_func(x), time_func(y)); @@ -482,15 +479,15 @@ static int latest_time_prioq_compare(const void *a, const void *b) { static int exit_prioq_compare(const void *a, const void *b) { const sd_event_source *x = a, *y = b; + int r; assert(x->type == SOURCE_EXIT); assert(y->type == SOURCE_EXIT); /* Enabled ones first */ - if (x->enabled != SD_EVENT_OFF && y->enabled == SD_EVENT_OFF) - return -1; - if (x->enabled == SD_EVENT_OFF && y->enabled != SD_EVENT_OFF) - return 1; + r = CMP(x->enabled == SD_EVENT_OFF, y->enabled == SD_EVENT_OFF); + if (r != 0) + return r; /* Lower priority values first */ if (x->priority < y->priority) |