summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>2020-07-09 23:23:07 +0200
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>2020-07-09 23:23:47 +0200
commit11f91d966905bdb7c773f51660d811e1e30b581b (patch)
tree8e188fd637c33db8d692442e060d05f570d897c1
parentad55490fa2b0ae39d2d99ed47f2aec720f30634d (diff)
downloadsystemd-cap-bpf-compat.tar.gz
basic/cap-list: reduce scope of variablescap-bpf-compat
-rw-r--r--src/basic/cap-list.c7
-rw-r--r--src/test/test-cap-list.c6
2 files changed, 4 insertions, 9 deletions
diff --git a/src/basic/cap-list.c b/src/basic/cap-list.c
index b449b9aeec..e55d96fbc4 100644
--- a/src/basic/cap-list.c
+++ b/src/basic/cap-list.c
@@ -18,7 +18,6 @@ static const struct capability_name* lookup_capability(register const char *str,
#include "cap-to-name.h"
const char *capability_to_name(int id) {
-
if (id < 0)
return NULL;
@@ -57,12 +56,11 @@ int capability_list_length(void) {
int capability_set_to_string_alloc(uint64_t set, char **s) {
_cleanup_free_ char *str = NULL;
- unsigned long i;
size_t allocated = 0, n = 0;
assert(s);
- for (i = 0; i <= cap_last_cap(); i++)
+ for (unsigned long i = 0; i <= cap_last_cap(); i++)
if (set & (UINT64_C(1) << i)) {
const char *p;
char buf[2 + 16 + 1];
@@ -95,11 +93,10 @@ int capability_set_to_string_alloc(uint64_t set, char **s) {
int capability_set_from_string(const char *s, uint64_t *set) {
uint64_t val = 0;
- const char *p;
assert(set);
- for (p = s;;) {
+ for (const char *p = s;;) {
_cleanup_free_ char *word = NULL;
int r;
diff --git a/src/test/test-cap-list.c b/src/test/test-cap-list.c
index 45a7231a20..2e90d667ae 100644
--- a/src/test/test-cap-list.c
+++ b/src/test/test-cap-list.c
@@ -12,12 +12,10 @@
/* verify the capability parser */
static void test_cap_list(void) {
- int i;
-
assert_se(!capability_to_name(-1));
assert_se(!capability_to_name(capability_list_length()));
- for (i = 0; i < capability_list_length(); i++) {
+ for (int i = 0; i < capability_list_length(); i++) {
const char *n;
assert_se(n = capability_to_name(i));
@@ -33,7 +31,7 @@ static void test_cap_list(void) {
assert_se(capability_from_name("15") == 15);
assert_se(capability_from_name("-1") == -EINVAL);
- for (i = 0; i < capability_list_length(); i++) {
+ for (int i = 0; i < capability_list_length(); i++) {
_cleanup_cap_free_charp_ char *a = NULL;
const char *b;
unsigned u;