summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDmitry V. Levin <ldv@strace.io>2023-04-04 08:00:00 +0000
committerDmitry V. Levin <ldv@strace.io>2023-04-04 08:00:00 +0000
commit2bece0624ff52a26ea58e26fc48f94e01a01ec9a (patch)
treed5240d1d113be0ba9ec23c826b995a13e02fbd3c
parent628b7eb7449e9557b409386cac85950f404ed0aa (diff)
downloadstrace-2bece0624ff52a26ea58e26fc48f94e01a01ec9a.tar.gz
tests: double quote array expansions to avoid re-splitting elements
This fixes shellcheck SC2068.
-rwxr-xr-xattic/qemu_multiarch_testing/make-hdc-img.sh2
-rwxr-xr-xtests/ioctl_block--pidns-translation.test2
-rwxr-xr-xtests/strace-p-Y-p.test2
3 files changed, 3 insertions, 3 deletions
diff --git a/attic/qemu_multiarch_testing/make-hdc-img.sh b/attic/qemu_multiarch_testing/make-hdc-img.sh
index f7fce90a0..e5c150f7a 100755
--- a/attic/qemu_multiarch_testing/make-hdc-img.sh
+++ b/attic/qemu_multiarch_testing/make-hdc-img.sh
@@ -11,7 +11,7 @@ cleanup()
fi
mountpoint -q hdc.img.dir ||
rm -rf hdc.img.dir
- exit $@
+ exit "$@"
}
trap 'cleanup $?' EXIT
diff --git a/tests/ioctl_block--pidns-translation.test b/tests/ioctl_block--pidns-translation.test
index d5655816b..e0cc41102 100755
--- a/tests/ioctl_block--pidns-translation.test
+++ b/tests/ioctl_block--pidns-translation.test
@@ -15,7 +15,7 @@ check_prog cut
check_prog grep
run_prog > /dev/null
-run_strace --pidns-translation -f -a16 -e trace=ioctl $@ $args > "$EXP"
+run_strace --pidns-translation -f -a16 -e trace=ioctl "$@" $args > "$EXP"
parent_pid="$(tail -n 2 $LOG | head -n 1 | cut -d' ' -f1)"
init_pid="$(tail -n 1 $LOG | cut -d' ' -f1)"
grep -E -v "^($parent_pid|$init_pid) |ioctl\([0123][,<]" "$LOG" > "$OUT"
diff --git a/tests/strace-p-Y-p.test b/tests/strace-p-Y-p.test
index 3dd204bbc..95bc7fe64 100755
--- a/tests/strace-p-Y-p.test
+++ b/tests/strace-p-Y-p.test
@@ -17,7 +17,7 @@ run_tracee()
{
local file
file="$1"; shift
- ../set_ptracer_any $@ > /dev/null 3> "$file" &
+ ../set_ptracer_any "$@" > /dev/null 3> "$file" &
pid=$!
while ! [ -s "$file" ]; do
kill -0 $pid 2> /dev/null ||