summaryrefslogtreecommitdiff
path: root/source3/selftest
Commit message (Collapse)AuthorAgeFilesLines
* selftest: Fix samba3.clustered.smb2.deny.deny2 testJoseph Sutton2023-04-121-1/+1
| | | | | | | | | This test failed to start, emitting the following error: Unknown torture operation 'clustered.smb2.deny.deny2' To fix this, remove the 'clustered.' prefix from the test name. Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andreas Schneider <asn@samba.org>
* selftest: Only run clusteredmember tests if ctdb is builtJoseph Sutton2023-04-121-49/+54
| | | | | | | Trying to run any of these tests without having built ctdb results in a failure, as the environment cannot be started. Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andreas Schneider <asn@samba.org>
* s3:selftest: Remove ad_dc_ntvfs for smbclient_machine_auth.plainAndreas Schneider2023-04-061-1/+1
| | | | | | | There is no need to run it against this environment and saves resources. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s3:selftest: Pass REALM to samba.blackbox.smbgetAndreas Schneider2023-04-051-0/+1
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15345 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3:selftest: Move samba3.blackbox.smbget to ad_memberAndreas Schneider2023-04-051-1/+14
| | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15345 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* torture3: Add tdb-validate testVolker Lendecke2023-04-011-0/+1
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=14789 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3: smbd: Fix dumb typos that meant smb1.SMB1-DFS-* tests were running ↵Jeremy Allison2023-03-311-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | against an SMB2-only fileserver. Remove knownfail on SMB1-DFS-SEARCH-PATHS, as we now pass it with the new SMB1 remove DFS paths before pathname processing changes. Note, we still fail: smb1.SMB1-DFS-PATHS.smbtorture\(fileserver_smb1\) smb1.SMB1-DFS-OPERATIONS.smbtorture\(fileserver_smb1\) even with the new SMB1 remove DFS paths before pathname processing as those tests test *very* specific Windows behaviors. We now pass many more of the individual internal tests, but in order to pass them all completely I need to add specific --with-sambaserver checks to avoid some of the Windows DFS SMB1 insanity (error messages). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Fri Mar 31 06:07:01 UTC 2023 on atb-devel-224
* tests: Add samba3.blackbox.zero_readsize test.Jeremy Allison2023-03-291-0/+12
| | | | | | | | | | | | | | | smbclient crashes when smbd has "smb2 max read = 0" in the [global] section of smb.conf. We should fail the protocol negotiation with NT_STATUS_INVALID_NETWORK_RESPONSE in this case. Adds knownfail. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15306 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: tests: Add new test_stream_dir_rename.sh test.Jeremy Allison2023-03-031-0/+4
| | | | | | | | | | | | | Shows we are leaking an fsp/fd if we request a non-existent stream on a file. This then causes rename of a directory containing the file to be denied, as it thinks we have an existing open file below it. Add knownfail. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15314 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3:test: Test winbind call depth tracePavel Filipenský2023-01-261-0/+5
| | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15287 Signed-off-by: Pavel Filipenský <pfilipensky@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Jan 26 15:07:57 UTC 2023 on atb-devel-224
* s3:tests: Add support for SMBD_DONT_LOG_STDOUT=1 in test_chdir_cache.shAndreas Schneider2023-01-261-1/+3
| | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15291 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* selftest: Only run samba.tests.smb3unix in developer modeAndreas Schneider2023-01-261-1/+4
| | | | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Jan 26 13:13:50 UTC 2023 on atb-devel-224
* s3: smbtorture: Add SMB2-DFS-FILENAME-LEADING-BACKSLASH test.Jeremy Allison2023-01-041-0/+14
| | | | | | | | | | | | | | | | Shows that we fail to cope with MacOSX clients that send a (or more than one) leading '\\' character for an SMB2 DFS pathname. I missed this in earlier tests as Windows, Linux, and libsmbclient clients do NOT send a leading backslash for SMB2 DFS paths. Only MacOSX (sigh:-). Passes against Windows. Adds a knownfail for smbd. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15277 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* selftest: add samba3.blackbox.registry_shareStefan Metzmacher2022-12-291-0/+4
| | | | | | | | | | | | This demonstrates the regression introduced by f03665bb7e8ea97699062630f2aa1bac4c5dfc7f, where registry shares are no longer listed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15243 BUG: https://bugzilla.samba.org/show_bug.cgi?id=15266 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Walker <awalker@ixsystems.com>
* CI: add a test for wbinfo --change-secret-at=DCRalph Boehme2022-12-211-0/+2
| | | | | | | | Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Dec 21 20:05:59 UTC 2022 on sn-devel-184
* tests: Show that in smb1 posix we don't treat dirs as case sensitiveVolker Lendecke2022-12-151-0/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: tests: Change smb2.compound_async to run against share aio_delay_inject ↵Jeremy Allison2022-12-011-1/+1
| | | | | | | | | | | | instead of tmp. It doesn't hurt the fsync compound async tests, and we need this for the next commits to ensure smb2_read/smb2_write compound tests take longer than 500ms so can be sure the last read/write in the compound will go async. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* tests: Start testing smb2 symlink error returnsVolker Lendecke2022-11-221-0/+1
| | | | | | | | | | This still all fails, but if you run them against Windows they work. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Nov 22 19:25:34 UTC 2022 on sn-devel-184
* tests: Start testing reparsepointsVolker Lendecke2022-11-221-0/+1
| | | | | | | | | | | | | | | | | | | | | | This still all fails, but if you run them against Windows they work. How to run: PYTHONPATH=bin/python \ LOCAL_PATH=/tmp \ SMB1_SHARE=share \ SMB2_SHARE=share \ SHARENAME=share \ SERVER_IP=<server-ip> \ DOMAIN=<your-domain> \ USERNAME=Administrator \ PASSWORD=<your-password> \ SMB_CONF_PATH=/usr/local/samba/etc/smb.conf \ SERVERCONFFILE="$SMB_CONF_PATH" \ python3 -m samba.subunit.run samba.tests.reparsepoints Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s4: torture: Add an async SMB2_OP_FLUSH + SMB2_OP_CLOSE test to ↵Jeremy Allison2022-11-171-0/+2
| | | | | | | | | | | | | | | | | | | smb2.compound_async. Shows we fail sending an SMB2_OP_FLUSH + SMB2_OP_CLOSE compound. Internally the flush goes async and we free the req, then we process the close. When the flush completes it tries to access already freed data. Found using the Apple MacOSX client at SNIA SDC 2022. Add knownfail. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15172 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: smbd: Add test to show smbd crashes when doing an FSCTL on a named ↵Jeremy Allison2022-11-141-0/+2
| | | | | | | | | | | stream handle. Add knownfail. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15236 Signed-off-by: Andrew Walker <awalker@ixsystems.com> Reviewed-by: Jeremy Allison <jra@samba.org>
* torture: Test the "server addresses" parameterVolker Lendecke2022-11-101-0/+5
| | | | | | | | | | | Thanks to Metze for the hint that all file servers already listen on 2 addressess -- V4 and V6 :-) Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Thu Nov 10 08:23:14 UTC 2022 on sn-devel-184
* torture: Show that "hide new files timeout" also hides directoriesVolker Lendecke2022-11-071-0/+11
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* torture3: Run the "hidenewfiles" test against SMB2Volker Lendecke2022-11-071-2/+2
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3: smbtorture3: Add new SMB2-DFS-SHARE-NON-DFS-PATH test.Jeremy Allison2022-09-281-0/+16
| | | | | | | | | | | | | | Uses non-DFS names and DFS-names against a DFS share, shows that Windows looks correctly at the DFS flag when SMB2 requests are made on a DFS share. Passes against Windows 2022. Mark as knownfail for smbd. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Noel Power <npower@samba.org> Autobuild-User(master): Noel Power <npower@samba.org> Autobuild-Date(master): Wed Sep 28 19:34:29 UTC 2022 on sn-devel-184
* s3: smbtorture3: Add an SMB1 operations torture tester.Jeremy Allison2022-09-141-0/+16
| | | | | | | | | | | | Only tests SMB1unlink for now, but I will add other operations later. smbtorture3 test is: SMB1-DFS-OPERATIONS. Passes fully against Windows. Adds knownfail for smbd. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* s3: smbtorture3: Add a new test SMB2-NON-DFS-SHARE.Jeremy Allison2022-09-141-0/+18
| | | | | | | | | | | | | | | | | This one is tricky. It sends SMB2 DFS pathnames to a non-DFS share, and sets the SMB2 flag FLAGS2_DFS_PATHNAMES in the SMB2 packet. Windows will have non of it and (correctly) treats the pathnames as local paths (they're going to a non-DFS share). Samba fails. This proves the server looks as the share DFS capability to override the flag in the SMB2 packet. Passes against Windows. Added knownfail for Samba. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* s3:tests: add test_smbXsrv_client_cross_node.shStefan Metzmacher2022-09-021-0/+7
| | | | | | | | | | | | | This demonstrates that a client-guid connected to ctdb node 0 caused a connection with the same client-guid to be rejected by ctdb node 1. Node 1 rejects the SMB2 Negotiate with NT_STATUS_NOT_SUPPORTED, because passing the multi-channel connection to a different node is not supported. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15159 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3: torture: Add a comprehensive SMB1 DFS path torture tester.Jeremy Allison2022-09-021-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | smbtorture3 test is: SMB1-DFS-PATHS Tests open, and then all 4 methods of renaming/hardlinking files: 1). SMBmv 2). SMBtrans2 SETPATHINFO 3). SMBtrans2 SETFILEINFO 4). SMBntrename Also added a test for SMB1findfirst. smbtorture3 test is: SMB1-DFS-SEARCH-PATHS. What this shows is that Windows strips off the SMB1findfirst mask *before* calling the DFS path parser (smbd currently does not). Added so we know how to fix the server code to match Windows behavior in parsing DFS paths in different calls going forward. Passes fully against Windows. Adds knownfails for smbd. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Noel Power <noel.power@suse.com>
* smbtorture: add a test trying to create a stream on share without streams ↵Ralph Boehme2022-09-021-0/+2
| | | | | | | | | | support BUG: https://bugzilla.samba.org/show_bug.cgi?id=15126 BUG: https://bugzilla.samba.org/show_bug.cgi?id=15161 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* tests: Add smb3 posix negotiate testsVolker Lendecke2022-09-021-0/+3
| | | | | | | | Make sure we do and don't announce posix depending on "smb3 unix extensions" parameter Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: torture: Add a comprehensive SMB2 DFS path torture tester.Jeremy Allison2022-08-301-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Passes fully against Windows. This shows that DFS paths on Windows on SMB2 must be of the form: SERVER\SHARE\PATH but the actual contents of the strings SERVER and SHARE don't need to match the given server or share. The algorithm the Windows server uses is the following: Look for a '\\' character, and assign anything before that to the SERVER component. The characters in this component are not checked for validity. Look for a second '\\' character and assign anything between the first and second '\\' characters to the SHARE component. The characters in the share component are checked for validity, but only ':' is flagged as an illegal sharename character despite what: [MS-FSCC] https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-fscc/dc9978d7-6299-4c5a-a22d-a039cdc716ea says. Anything after the second '\\' character is assigned to the PATH component and becomes the share-relative path. If there aren't two '\\' characters it removes everything and ends up with the empty string as the share relative path. To give some examples, the following pathnames all map to the directory at the root of the DFS share: SERVER\SHARE SERVER "" ANY\NAME ANY ::::\NAME the name: SERVER\: is illegal (sharename contains ':') and the name: ANY\NAME\file maps to a share-relative pathname of "file", despite "ANY" not being the server name, and "NAME" not being the DFS share name we are connected to. Adds a knownfail for smbd as our current code in parse_dfs_path() is completely incorrect here and tries to map "incorrect" DFS names into local paths. I will work on fixing this later, but we should be able to remove parse_dfs_path() entirely and move the DFS pathname logic before the call to filename_convert_dirfsp() in the same way Volker suggested and was able to achieve for extract_snapshot_token() and the @GMT pathname processing. Also proves the "target" paths for SMB2_SETINFO rename and hardlink must *not* be DFS-paths. Next I will work on a torture tester for SMB1 DFS paths. Signed-off-by: Jeremy Allison <jra@samba.org> Reivewed-by: Noel Power <npower@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Aug 30 17:10:33 UTC 2022 on sn-devel-184
* s3: tests: Add samba3.blackbox.test_veto_files.Jeremy Allison2022-08-161-0/+4
| | | | | | | | | | | | | | Shows we currently don't look at smb.conf veto files parameter when opening a file or directory. Checks multi-component paths. Also checks veto files that might be hidden behind a mangled name. Add knownfail. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15143 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* CI: add a test trying to delete a stream on a pathref ("stat open") handleRalph Boehme2022-08-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When using vfs_streams_xattr, for a pathref handle of a stream the system fd will be a fake fd created by pipe() in vfs_fake_fd(). For the following callchain we wrongly pass a stream fsp to SMB_VFS_FGET_NT_ACL(): SMB_VFS_CREATE_FILE(..., "file:stream", ...) => open_file(): if (open_fd): -> taking the else branch: -> smbd_check_access_rights_fsp(stream_fsp) -> SMB_VFS_FGET_NT_ACL(stream_fsp) This is obviously wrong and can lead to strange permission errors when using vfs_acl_xattr: in vfs_acl_xattr we will try to read the stored ACL by calling fgetxattr(fake-fd) which of course faild with EBADF. Now unfortunately the vfs_acl_xattr code ignores the specific error and handles this as if there was no ACL stored and subsequently runs the code to synthesize a default ACL according to the setting of "acl:default acl style". As the correct access check for streams has already been carried out by calling check_base_file_access() from create_file_unixpath(), the above problem is not a security issue: it can only lead to "decreased" permissions resulting in unexpected ACCESS_DENIED errors. The fix is obviously going to be calling smbd_check_access_rights_fsp(stream_fsp->base_fsp). This test verifies that deleting a file works when the stored NT ACL grants DELETE_FILE while the basic POSIX permissions (used in the acl_xattr fallback code) do not. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15126 MR: https://gitlab.com/samba-team/samba/-/merge_requests/2643 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* s4:torture: Rename rpc.samr.passwords testsAndreas Schneider2022-07-151-1/+1
| | | | | | This way it is easier to select them with 'make test'. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
* s3:selftest: Reformat rpc arrayAndreas Schneider2022-07-151-15/+51
| | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
* CI: fix check for correct mdsvc resonse when connecting to a share with ↵Ralph Boehme2022-07-121-1/+1
| | | | | | | | | | | | | | Spotlight disabled A Mac SMB server returns an all zero handle and an empty path if Spotlight is disabled on a share. We must return the exact same error return in order to trigger client-side searching. Bug: https://bugzilla.samba.org/show_bug.cgi?id=15086 pcap: https://www.samba.org/~slow/pcaps/mac-bigsur-smbserver-spotlight-disabled.pcapng.gz Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* vfs_acl_xattr: add acl_xattr:security_acl_name optionRalph Boehme2022-06-271-0/+2
| | | | | Pair-Programmed-With: Jeremy Allison <jra@samba.org> Signed-off-by: Ralph Boehme <slow@samba.org>
* s3: tests: Add test that shows smbd crashes using vfs_fruit with ↵Jeremy Allison2022-06-201-0/+4
| | | | | | | | | | | fruit:resource = stream on deleting a file. Add knownfail. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15099 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* s3: test: Add tests to show we still connect to a full_audit share with a ↵Jeremy Allison2022-06-171-0/+6
| | | | | | | | | | | bad success or fail VFS names. Add knownfail. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15098 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3:smbd implement volume serial number parameterChristian Ambach2022-06-061-0/+3
| | | | | | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=14765 RN: add new smb.conf parameter "volume serial number" to allow overriding the generated default value Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed=by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Mon Jun 6 17:42:37 UTC 2022 on sn-devel-184
* selftest: Test for bug 15062 -- list "username" in netshareenumVolker Lendecke2022-05-181-0/+6
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=15062 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* CI: use native Python functions to detect system and releaseRalph Boehme2022-04-281-2/+4
| | | | | | | | | | | | | This ensures we detect the runtime system and release, not the ones when Samba was build. It's necessary to detect the correct kernel version we're running on because for kernels before 5.3.1 O_PATH opens unnecessarily broke kernel oplocks, which breaks our tests. And in gitlab it can happen that we build on kernels after 5.3.1 and later run on older kernels. In this situation we can't run kernel oplock tests. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3:tests Test "username map" for UNIX groupsPavel Filipenský2022-04-071-0/+2
| | | | | | | | BUG: https://bugzilla.samba.org/show_bug.cgi?id=15041 Signed-off-by: Pavel Filipenský <pfilipen@redhat.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* smbd: remove itime and file_id logic and codeRalph Boehme2022-03-311-2/+0
| | | | | | | | | | | | | | | | | | This bases File-Ids on the inode numbers again. The whole stuff was added because at that time Apple clients 1. would be upset by inode number reusage and 2. had a client side bug in their fallback implemetentation that assigns File-Ids on the client side in case the server provides File-Ids of 0. After discussion with folks at Apple it should be safe these days to rely on the Mac to generate its own File-Ids and let Samba return 0 File-Ids. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* CI: consolidate SMB2-FILEID and SMB2-FILEID-UNIQUE torture test suitesRalph Boehme2022-03-311-2/+0
| | | | | | | | We don't need seperate test suites here, all tests are related to File-Ids. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* CI: avoid smb2.twrp being run by plansmbtorture4testsuite() directlyRalph Boehme2022-03-311-0/+3
| | | | | | | | | This should only be run by a blackbox test. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15035 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3: tests.py: Only run smb2.rename against fileserver.Jeremy Allison2022-03-301-0/+2
| | | | | | | | | No need to run this against nt4_dc or ad_dc. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15038 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* s3: torture: Add 2 new tests SMB2-DEL-ON-CLOSE-NONWRITE-DELETE-NO, ↵Jeremy Allison2022-03-221-0/+28
| | | | | | | | | | | | | | | | | | | | | | SMB2-DEL-ON-CLOSE-NONWRITE-DELETE-YES. We currently allow setting the delete on close bit for a directory containing only explicitly hidden/vetoed files in the case where "delete veto files = yes" *and* "delete veto files = no". For the "delete veto files = no" case we should be denying setting the delete on close bit when the client tries to set it (that's the only time Windows looks at the bit and returns an error to the user). We already do the in the dangling symlink case, we just missed it in the !is_visible_fsp() case. Mark SMB2-DEL-ON-CLOSE-NONWRITE-DELETE-NO as knownfail for now. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15023 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Noel Power <npower@samba.org>
* selftest: Remove duplicate run of rpc.lsa tests against ad_dc as "samba3"Andrew Bartlett2022-03-171-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Running these tests twice is a waste (sorry, thas was my choice when merging s3 and s4 to just run all the tests against the AD DC) and more importantly means that tests are run in "samba3" mode against the AD DC, making it difficult to change the tests to expect a different behaivour against the AD DC compared to the NT4 DC. To assure that we have not lost tests, I ran: grep command st/subunit | grep ad_dc| cut -f 2 -d\" | cut -f 2- -d. | sort | uniq -c The two blocks (for rpc.lsa and rpc.lsa.*) are because the rpc.lsa.* subtests were not previously run under ncacn_ip_tcp: and this is the minimal change. The output is: --- /tmp/3 2022-02-12 14:01:50.435761067 +1300 +++ /tmp/now 2022-02-12 14:01:37.427595351 +1300 @@ -13,9 +13,8 @@ 2 rpc.lsa-getuser on ncalrpc with validate. 2 rpc.lsa-getuser with bigendian. 2 rpc.lsa-getuser with seal,padcheck. 2 rpc.lsa-getuser with validate. - 2 rpc.lsa.lookupnames. 2 rpc.lsa.lookupnames with . 2 rpc.lsa.lookupnames with bigendian. 2 rpc.lsa.lookupnames with validate. 2 rpc.lsalookup on ncacn_ip_tcp with bigendian. @@ -26,9 +25,8 @@ 2 rpc.lsalookup on ncacn_np with validate. 2 rpc.lsalookup on ncalrpc with bigendian. 2 rpc.lsalookup on ncalrpc with seal,padcheck. 2 rpc.lsalookup on ncalrpc with validate. - 2 rpc.lsa.lookupsids. 2 rpc.lsa.lookupsids with . 2 rpc.lsa.lookupsids with bigendian. 2 rpc.lsa.lookupsids with validate. 2 rpc.lsalookup with bigendian. @@ -42,15 +40,11 @@ 2 rpc.lsa on ncacn_np with validate. 2 rpc.lsa on ncalrpc with bigendian. 2 rpc.lsa on ncalrpc with seal,padcheck. 2 rpc.lsa on ncalrpc with validate. - 2 rpc.lsa over ncacn_ip_tcp . - 2 rpc.lsa over ncacn_np . - 2 rpc.lsa.privileges. 2 rpc.lsa.privileges with . 2 rpc.lsa.privileges with bigendian. 2 rpc.lsa.privileges with validate. - 2 rpc.lsa.secrets. 2 rpc.lsa.secrets on ncacn_np with with -k no --option=clientusespnego=no. 2 rpc.lsa.secrets on ncacn_np with with -k no --option=clientusespnego=no --option=clientntlmv2auth=yes. 2 rpc.lsa.secrets on ncacn_np with with -k no --option=clientusespnego=yes. 2 rpc.lsa.secrets on ncacn_np with with -k no --option=clientusespnego=yes --option=clientntlmv2auth=yes. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
View Lorry Controller Status