summaryrefslogtreecommitdiff
path: root/testsuite
diff options
context:
space:
mode:
authorGary Lockyer <gary@catalyst.net.nz>2017-11-03 13:35:41 +1300
committerAndrew Bartlett <abartlet@samba.org>2017-11-20 07:20:13 +0100
commitd11473b15df9f1688b6de387b822583f4045ac3d (patch)
tree91474bd6d8d391f0f68730040fbd947e864aa508 /testsuite
parent88bdecae0a152d8c07859d437d02116d1f18087f (diff)
downloadsamba-d11473b15df9f1688b6de387b822583f4045ac3d.tar.gz
source3: remove sock_exec
Remove the sock_exec code which is no longer needed and additionally has been used by exploit code. This was originally test support code, the tests relying on the sock_exec code have been removed. Past exploits have used sock_exec as a proxy for system() matching a talloc destructor prototype. See for example: Exploit for Samba vulnerabilty (CVE-2015-0240) at https://gist.github.com/worawit/051e881fc94fe4a49295 and the Red Hat post at https://access.redhat.com/blogs/766093/posts/1976553 Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Mon Nov 20 07:20:13 CET 2017 on sn-devel-144
Diffstat (limited to 'testsuite')
-rw-r--r--testsuite/build_farm/basicsmb.fns2
1 files changed, 0 insertions, 2 deletions
diff --git a/testsuite/build_farm/basicsmb.fns b/testsuite/build_farm/basicsmb.fns
index 3a9080f473b..d1127e872dd 100644
--- a/testsuite/build_farm/basicsmb.fns
+++ b/testsuite/build_farm/basicsmb.fns
@@ -177,8 +177,6 @@ test_listfilesauth_should_deny() {
return 0
}
-echo "LIBSMB_PROG=$LIBSMB_PROG" >&2
-
# Give sensible defaults to some variables.