From d11473b15df9f1688b6de387b822583f4045ac3d Mon Sep 17 00:00:00 2001 From: Gary Lockyer Date: Fri, 3 Nov 2017 13:35:41 +1300 Subject: source3: remove sock_exec Remove the sock_exec code which is no longer needed and additionally has been used by exploit code. This was originally test support code, the tests relying on the sock_exec code have been removed. Past exploits have used sock_exec as a proxy for system() matching a talloc destructor prototype. See for example: Exploit for Samba vulnerabilty (CVE-2015-0240) at https://gist.github.com/worawit/051e881fc94fe4a49295 and the Red Hat post at https://access.redhat.com/blogs/766093/posts/1976553 Signed-off-by: Gary Lockyer Reviewed-by: Andrew Bartlett Reviewed-by: Garming Sam Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Mon Nov 20 07:20:13 CET 2017 on sn-devel-144 --- testsuite/build_farm/basicsmb.fns | 2 -- 1 file changed, 2 deletions(-) (limited to 'testsuite') diff --git a/testsuite/build_farm/basicsmb.fns b/testsuite/build_farm/basicsmb.fns index 3a9080f473b..d1127e872dd 100644 --- a/testsuite/build_farm/basicsmb.fns +++ b/testsuite/build_farm/basicsmb.fns @@ -177,8 +177,6 @@ test_listfilesauth_should_deny() { return 0 } -echo "LIBSMB_PROG=$LIBSMB_PROG" >&2 - # Give sensible defaults to some variables. -- cgit v1.2.1