diff options
| author | Noel Power <noel.power@suse.com> | 2019-07-05 10:24:53 +0000 |
|---|---|---|
| committer | Gary Lockyer <gary@samba.org> | 2019-07-24 04:19:27 +0000 |
| commit | 765fc314e4aee455bae0f391a7d388584b48bb4a (patch) | |
| tree | 8c09bd66129a4f0b78903eba804887b761dadf63 /source4 | |
| parent | 256684c7a86301d26d6cf7298fb70e647bf45cf5 (diff) | |
| download | samba-765fc314e4aee455bae0f391a7d388584b48bb4a.tar.gz | |
s4/auth/kerberos: clang: Fix 'value stored to 'ret' is never read '
Fixes:
source4/auth/kerberos/kerberos_pac.c:116:2: warning: Value stored to 'ret' is never read <--[clang]
ret = smb_krb5_make_pac_checksum(mem_ctx,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Diffstat (limited to 'source4')
| -rw-r--r-- | source4/auth/kerberos/kerberos_pac.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/source4/auth/kerberos/kerberos_pac.c b/source4/auth/kerberos/kerberos_pac.c index e45a846cd88..54ef4d61b02 100644 --- a/source4/auth/kerberos/kerberos_pac.c +++ b/source4/auth/kerberos/kerberos_pac.c @@ -120,6 +120,13 @@ &srv_checksum->type, &srv_checksum->signature); + if (ret) { + DBG_WARNING("making krbtgt PAC srv_checksum failed: %s\n", + smb_get_krb5_error_message(context, ret, mem_ctx)); + talloc_free(pac_data); + return ret; + } + /* Then sign Server checksum */ ret = smb_krb5_make_pac_checksum(mem_ctx, &srv_checksum->signature, @@ -128,8 +135,8 @@ &kdc_checksum->type, &kdc_checksum->signature); if (ret) { - DEBUG(2, ("making krbtgt PAC checksum failed: %s\n", - smb_get_krb5_error_message(context, ret, mem_ctx))); + DBG_WARNING("making krbtgt PAC kdc_checksum failed: %s\n", + smb_get_krb5_error_message(context, ret, mem_ctx)); talloc_free(pac_data); return ret; } |