summaryrefslogtreecommitdiff
path: root/source4/rpc_server/winreg
diff options
context:
space:
mode:
authorAndrew Tridgell <tridge@samba.org>2005-08-17 13:09:42 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 13:33:28 -0500
commit0d425487da05db23a1a2f0f67e34bce3c5d80d7e (patch)
tree819887063f21145a3d11799f8788f6c58d26fef0 /source4/rpc_server/winreg
parenta152245a998923888e201d4488b8dc16619d96a1 (diff)
downloadsamba-0d425487da05db23a1a2f0f67e34bce3c5d80d7e.tar.gz
r9359: don't check for size overflow if value is NULL
this gets viewing the product options in smbd HKLM from w2k3 regedit working (This used to be commit 17f3250dd61bc9aad5cf3804e271383e219752f6)
Diffstat (limited to 'source4/rpc_server/winreg')
-rw-r--r--source4/rpc_server/winreg/rpc_winreg.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/source4/rpc_server/winreg/rpc_winreg.c b/source4/rpc_server/winreg/rpc_winreg.c
index 2cbac091bb6..400041451fe 100644
--- a/source4/rpc_server/winreg/rpc_winreg.c
+++ b/source4/rpc_server/winreg/rpc_winreg.c
@@ -209,7 +209,8 @@ static WERROR winreg_EnumValue(struct dcesrv_call_state *dce_call, TALLOC_CTX *m
}
/* check the client has enough room for the value */
- if (r->in.size != NULL &&
+ if (r->in.value != NULL &&
+ r->in.size != NULL &&
value->data_len > *r->in.size) {
return WERR_MORE_DATA;
}