diff options
| author | Douglas Bagnall <douglas.bagnall@catalyst.net.nz> | 2018-04-24 12:40:32 +1200 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2019-02-01 03:36:17 +0100 |
| commit | b313a6aa9db15b2905646074d5e22db47a7c972c (patch) | |
| tree | f4954b00c9db02fa55c2484de4b5f3faecac79f5 /source4/param | |
| parent | 1f9ac9135c4d4e6173ac2d39b93b8d96e1f038ee (diff) | |
| download | samba-b313a6aa9db15b2905646074d5e22db47a7c972c.tar.gz | |
s4/param/provision: check samdb argument in provision_bare()
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'source4/param')
| -rw-r--r-- | source4/param/provision.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/source4/param/provision.c b/source4/param/provision.c index ee84cd021e1..48a471cf44d 100644 --- a/source4/param/provision.c +++ b/source4/param/provision.c @@ -81,6 +81,7 @@ NTSTATUS provision_bare(TALLOC_CTX *mem_ctx, struct loadparm_context *lp_ctx, { const char *configfile; PyObject *provision_mod, *provision_dict, *provision_fn, *py_result, *parameters, *py_lp_ctx; + struct ldb_context *samdb; DEBUG(0,("Provision for Become-DC test using python\n")); @@ -189,8 +190,12 @@ NTSTATUS provision_bare(TALLOC_CTX *mem_ctx, struct loadparm_context *lp_ctx, return NT_STATUS_UNSUCCESSFUL; } result->lp_ctx = lpcfg_from_py_object(mem_ctx, py_lp_ctx); - result->samdb = pyldb_Ldb_AsLdbContext(PyObject_GetAttrString(py_result, "samdb")); - + samdb = pyldb_Ldb_AsLdbContext(PyObject_GetAttrString(py_result, "samdb")); + if (samdb == NULL) { + DEBUG(0, ("Missing 'samdb' attribute")); + return NT_STATUS_UNSUCCESSFUL; + } + result->samdb = samdb; return NT_STATUS_OK; } |