summaryrefslogtreecommitdiff
path: root/source4/libcli
diff options
context:
space:
mode:
authorNoel Power <noel.power@suse.com>2019-07-11 11:33:18 +0000
committerGary Lockyer <gary@samba.org>2019-07-16 22:52:24 +0000
commit06c3a493d99846af62c185a9db1a6823726ac1fc (patch)
treeee22b6afa039e43f2b2858e33c2f2db7e66c80a9 /source4/libcli
parentbe319e24bb96ac4acbf55f36403f37af08107660 (diff)
downloadsamba-06c3a493d99846af62c185a9db1a6823726ac1fc.tar.gz
s4/libcli/raw: clang: Fix 'initialization value is never read'
Fixes: source4/libcli/raw/rawnegotiate.c:157:11: warning: Value stored to 'status' during its initialization is never read <--[clang] NTSTATUS status = NT_STATUS_INTERNAL_ERROR; ^~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Diffstat (limited to 'source4/libcli')
-rw-r--r--source4/libcli/raw/rawnegotiate.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/source4/libcli/raw/rawnegotiate.c b/source4/libcli/raw/rawnegotiate.c
index cec081c364a..51c6f0f9ecb 100644
--- a/source4/libcli/raw/rawnegotiate.c
+++ b/source4/libcli/raw/rawnegotiate.c
@@ -154,7 +154,7 @@ NTSTATUS smb_raw_negotiate_recv(struct tevent_req *req)
NTSTATUS smb_raw_negotiate(struct smbcli_transport *transport, bool unicode,
int minprotocol, int maxprotocol)
{
- NTSTATUS status = NT_STATUS_INTERNAL_ERROR;
+ NTSTATUS status;
struct tevent_req *subreq = NULL;
bool ok;
@@ -164,7 +164,8 @@ NTSTATUS smb_raw_negotiate(struct smbcli_transport *transport, bool unicode,
minprotocol,
maxprotocol);
if (subreq == NULL) {
- return NT_STATUS_NO_MEMORY;
+ status = NT_STATUS_NO_MEMORY;
+ goto failed;
}
ok = tevent_req_poll(subreq, transport->ev);