diff options
author | Aaron Haslett <aaronhaslett@catalyst.net.nz> | 2019-03-28 15:54:06 +1300 |
---|---|---|
committer | Garming Sam <garming@samba.org> | 2019-05-06 05:45:55 +0000 |
commit | bc1583d368902c2e384ed0080c8de003b982a6f7 (patch) | |
tree | 23eb6cd34be8fefba551aa12a1f868f10befe953 /source4/dsdb/tests/python/sec_descriptor.py | |
parent | 64bccb9bca77b0b7b46f645267f81f879f31e3d1 (diff) | |
download | samba-bc1583d368902c2e384ed0080c8de003b982a6f7.tar.gz |
selftest: correcting empty attribute usage in requests
Many parts of Samba use an empty attribute list in requests expecting
all attributes to be returned in the response, which is incorrect. This
patch corrects the instances found by current CI tests. Static analysis
and debugging will need to be done before changing ildap to the correct
semantics.
Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Mon May 6 05:45:55 UTC 2019 on sn-devel-184
Diffstat (limited to 'source4/dsdb/tests/python/sec_descriptor.py')
-rwxr-xr-x | source4/dsdb/tests/python/sec_descriptor.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source4/dsdb/tests/python/sec_descriptor.py b/source4/dsdb/tests/python/sec_descriptor.py index 5e0f1453423..a495356ac48 100755 --- a/source4/dsdb/tests/python/sec_descriptor.py +++ b/source4/dsdb/tests/python/sec_descriptor.py @@ -1847,7 +1847,7 @@ class SdFlagsDescriptorTests(DescriptorTests): self.assertFalse("nTSecurityDescriptor" in res[0]) res = self.ldb_admin.search(self.base_dn, SCOPE_BASE, None, - [], controls=["sd_flags:1:%d" % (sd_flags)]) + controls=["sd_flags:1:%d" % (sd_flags)]) self.assertTrue("nTSecurityDescriptor" in res[0]) tmp = res[0]["nTSecurityDescriptor"][0] sd = ndr_unpack(security.descriptor, tmp) |