diff options
| author | Volker Lendecke <vl@samba.org> | 2017-06-17 08:48:16 +0200 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2017-06-21 07:30:39 +0200 |
| commit | a2436b67e5dd47d955a3bea2b83e0693b627ab96 (patch) | |
| tree | df204d66f0fb2f6f82d02d7414265c2c99dd4205 /source3/torture | |
| parent | 46a1ae5d71dd5266d87a3563ca8e800912138327 (diff) | |
| download | samba-a2436b67e5dd47d955a3bea2b83e0693b627ab96.tar.gz | |
messaging: Deliver messages only once
This survived an autobuild, so no subsystem strictly needs this anymore. In
particular the notify subsystem has been rewritten.
Why this patch? It removes some complexity from core code, and it reduces the
potential memory overconsumption: Right now I'm working on a g_lock_ping_pong
test. This test does a lot of messaging_filtered_read_send calls in a tight
loop on a nested event context. With the current code we let the
messaging_filtered_read code consume the message that arrives, but it also
posts it for consumption by the main event context attached to the messaging
context with its "classic" callback. This test never comes back to the main
event context, so it accumulates more and more self-posted messages. That's
just unnecessary, given that due to the successful autobuild nothing but the
read1 test makes use of the "multicasting" of messages.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jun 21 07:30:39 CEST 2017 on sn-devel-144
Diffstat (limited to 'source3/torture')
| -rw-r--r-- | source3/torture/test_messaging_read.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/source3/torture/test_messaging_read.c b/source3/torture/test_messaging_read.c index 43b4367c11d..d3e4079074b 100644 --- a/source3/torture/test_messaging_read.c +++ b/source3/torture/test_messaging_read.c @@ -122,7 +122,7 @@ bool run_messaging_read1(int dummy) goto fail; } - for (i=0; i<3; i++) { + for (i=0; i<2; i++) { if (tevent_loop_once(ev) != 0) { fprintf(stderr, "tevent_loop_once failed\n"); goto fail; @@ -131,8 +131,8 @@ bool run_messaging_read1(int dummy) printf("%u/%u\n", count1, count2); - if ((count1 != 1) || (count2 != 1)){ - fprintf(stderr, "Got %u/%u msgs, expected 1 each\n", + if ((count1 != 1) || (count2 != 0)) { + fprintf(stderr, "Got %u/%u msgs, expected 1/0\n", count1, count2); goto fail; } |