summaryrefslogtreecommitdiff
path: root/source3/smbd/uid.c
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2019-07-19 11:14:13 +0200
committerJeremy Allison <jra@samba.org>2019-09-11 19:59:34 +0000
commit5da24aa18e9c0ff6f2852b5421945111ef5c6b2b (patch)
treef5777d28bbb00a75986797f175585ebda5a8e2dc /source3/smbd/uid.c
parent15699475d6031dd0ed5cd24e9915c574b35a233b (diff)
downloadsamba-5da24aa18e9c0ff6f2852b5421945111ef5c6b2b.tar.gz
smbd: rename [un]become_user*() to [un]become_user_without_service*()
We should make the behavior change (that gives up some protection) more obvious, by changing the function names. At least some OEMs have patches relying on the 4.9/4.10 behaviour and we want them to detect that they have to do more work when they need to change directories. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
Diffstat (limited to 'source3/smbd/uid.c')
-rw-r--r--source3/smbd/uid.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/source3/smbd/uid.c b/source3/smbd/uid.c
index 106f1430011..0e8d5bca4de 100644
--- a/source3/smbd/uid.c
+++ b/source3/smbd/uid.c
@@ -659,7 +659,7 @@ void smbd_unbecome_root(void)
Saves and restores the connection context.
****************************************************************************/
-bool become_user(connection_struct *conn, uint64_t vuid)
+bool become_user_without_service(connection_struct *conn, uint64_t vuid)
{
struct user_struct *vuser;
int snum = SNUM(conn);
@@ -696,12 +696,12 @@ bool become_user(connection_struct *conn, uint64_t vuid)
return true;
}
-bool become_user_by_fsp(struct files_struct *fsp)
+bool become_user_without_service_by_fsp(struct files_struct *fsp)
{
- return become_user(fsp->conn, fsp->vuid);
+ return become_user_without_service(fsp->conn, fsp->vuid);
}
-bool become_user_by_session(connection_struct *conn,
+bool become_user_without_service_by_session(connection_struct *conn,
const struct auth_session_info *session_info)
{
bool ok;
@@ -726,7 +726,7 @@ bool become_user_by_session(connection_struct *conn,
return true;
}
-bool unbecome_user(void)
+bool unbecome_user_without_service(void)
{
pop_sec_ctx();
pop_conn_ctx();