diff options
| author | Volker Lendecke <vl@samba.org> | 2019-05-27 11:24:14 +0200 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2019-11-13 00:20:55 +0000 |
| commit | 3fea05e01f845588eb0de63af435bfec670593be (patch) | |
| tree | 91f3d63cf87fddc636b10af9095306fdbaba6beb /source3/smbd/smb2_flush.c | |
| parent | a0aaf5c3345239959221d6c2e9cd949b8ccdf233 (diff) | |
| download | samba-3fea05e01f845588eb0de63af435bfec670593be.tar.gz | |
smbd: Remove write cache
Since this was written, our write path has changed significantly. In
particular we have gained very flexible support for async I/O, with the
linux io_uring in the pipeline. Caching stuff in main memory and then
doing a blocking pwrite nowadays does not belong into the core smbd
code. If someone wants it back, it should be doable in a VFS module.
Removes: "write cache size" parameter.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Nov 13 00:20:55 UTC 2019 on sn-devel-184
Diffstat (limited to 'source3/smbd/smb2_flush.c')
| -rw-r--r-- | source3/smbd/smb2_flush.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/source3/smbd/smb2_flush.c b/source3/smbd/smb2_flush.c index 470a8df4944..86d5bbc58f0 100644 --- a/source3/smbd/smb2_flush.c +++ b/source3/smbd/smb2_flush.c @@ -125,7 +125,6 @@ static struct tevent_req *smbd_smb2_flush_send(TALLOC_CTX *mem_ctx, struct tevent_req *subreq; struct smbd_smb2_flush_state *state; struct smb_request *smbreq; - int ret; req = tevent_req_create(mem_ctx, &state, struct smbd_smb2_flush_state); @@ -187,12 +186,6 @@ static struct tevent_req *smbd_smb2_flush_send(TALLOC_CTX *mem_ctx, return tevent_req_post(req, ev); } - ret = flush_write_cache(fsp, SAMBA_SYNC_FLUSH); - if (ret == -1) { - tevent_req_nterror(req, map_nt_error_from_unix(errno)); - return tevent_req_post(req, ev); - } - subreq = SMB_VFS_FSYNC_SEND(state, ev, fsp); if (tevent_req_nomem(subreq, req)) { return tevent_req_post(req, ev); |