diff options
| author | Volker Lendecke <vl@samba.org> | 2019-06-30 19:51:13 +0200 |
|---|---|---|
| committer | Ralph Boehme <slow@samba.org> | 2019-07-04 14:03:29 +0000 |
| commit | 8bae5d82e2a101d37f5572e1d174b37816576840 (patch) | |
| tree | d7be69f5f1dd2cff49fc67eb8f409f817a9b061a /source3/smbd/proto.h | |
| parent | 2d7efba0d9dd212df127ffd697ff72fb30b72861 (diff) | |
| download | samba-8bae5d82e2a101d37f5572e1d174b37816576840.tar.gz | |
smbd: Don't store num_read_oplocks in brlock.tdb
This removes a kludgy implementation that worked around a locking
hierarchy problem: Setting a byte range lock had to contend the level2
oplocks, which are stored in locking.tdb/leases.tdb. We could not
access locking.tdb in the brlock.tdb code, as brlock.tdb might have
been locked first without locking.tdb, violating the locking hierarchy
locking.tdb->brlock.tdb. Now that that problem is gone (see the commit
wrapping do_lock() in share_mode_do_locked()), we can remove this
kludge.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Diffstat (limited to 'source3/smbd/proto.h')
| -rw-r--r-- | source3/smbd/proto.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/source3/smbd/proto.h b/source3/smbd/proto.h index 2f28cf2076f..076702feca5 100644 --- a/source3/smbd/proto.h +++ b/source3/smbd/proto.h @@ -725,7 +725,6 @@ NTSTATUS get_relative_fid_filename(connection_struct *conn, uint32_t get_lease_type(const struct share_mode_data *d, const struct share_mode_entry *e); -bool update_num_read_oplocks(files_struct *fsp, struct share_mode_lock *lck); void break_kernel_oplock(struct messaging_context *msg_ctx, files_struct *fsp); NTSTATUS set_file_oplock(files_struct *fsp); |