diff options
| author | Stefan Metzmacher <metze@samba.org> | 2017-10-18 13:36:59 +0200 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2017-10-20 04:05:20 +0200 |
| commit | 90d57ec08c7af7b678b753b9d17bf7c4ac1d6dd0 (patch) | |
| tree | 4701482d943e0ad918c39f57982d9e7d5305c158 /source3/rpc_client | |
| parent | 1d1e1da263313ce572a1601d9b630188ba643bb4 (diff) | |
| download | samba-90d57ec08c7af7b678b753b9d17bf7c4ac1d6dd0.tar.gz | |
s3:cli_netlogon: make sure rpccli_connect_netlogon only returns NT_STATUS_OK on success
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'source3/rpc_client')
| -rw-r--r-- | source3/rpc_client/cli_netlogon.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/source3/rpc_client/cli_netlogon.c b/source3/rpc_client/cli_netlogon.c index 616523ec371..469d348f6b9 100644 --- a/source3/rpc_client/cli_netlogon.c +++ b/source3/rpc_client/cli_netlogon.c @@ -354,15 +354,16 @@ again: status = cli_rpc_pipe_open_bind_schannel( cli, &ndr_table_netlogon, transport, creds_ctx, &rpccli); - if (!NT_STATUS_IS_OK(status)) { - DBG_DEBUG("cli_rpc_pipe_open_bind_schannel " - "failed: %s\n", nt_errstr(status)); - } if (NT_STATUS_EQUAL(status, NT_STATUS_NETWORK_ACCESS_DENIED)) { DBG_DEBUG("Retrying with serverauthenticate\n"); TALLOC_FREE(lck); goto again; } + if (!NT_STATUS_IS_OK(status)) { + DBG_DEBUG("cli_rpc_pipe_open_bind_schannel " + "failed: %s\n", nt_errstr(status)); + goto fail; + } goto done; } @@ -399,6 +400,7 @@ again: if (!NT_STATUS_IS_OK(status)) { DBG_DEBUG("cli_rpc_pipe_open_noauth_transport " "failed: %s\n", nt_errstr(status)); + goto fail; } goto done; } @@ -434,6 +436,7 @@ again: if (!NT_STATUS_IS_OK(status)) { DBG_DEBUG("cli_rpc_pipe_open_noauth_transport " "failed: %s\n", nt_errstr(status)); + goto fail; } goto done; } |