summaryrefslogtreecommitdiff
path: root/source3/printing
diff options
context:
space:
mode:
authorDavid Disseldorp <ddiss@samba.org>2015-02-03 19:26:42 +0100
committerJeremy Allison <jra@samba.org>2015-02-10 01:38:57 +0100
commit2f4998113e539ea4ba6fb0a72ba6ac25c9d74bd6 (patch)
tree296a8068a741d065b34ebe3b71d75ee0d26e3384 /source3/printing
parent600b40db9d95c20c04fd517165dff81b20e35e8e (diff)
downloadsamba-2f4998113e539ea4ba6fb0a72ba6ac25c9d74bd6.tar.gz
printing/cups: pack requested-attributes with IPP_TAG_KEYWORD
The CUPS IPP_GET_JOBS requested-attributes array indicates which job attributes the caller would like in the cupsd response. Until now, Samba has packed these attributes with a IPP_TAG_NAME format tag. In recent versions of CUPS, this results in the IPP_GET_JOBS response only including the job-id and job-printer-uri fields, even with JobPrivateValues=none configured. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10808 Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Feb 10 01:38:58 CET 2015 on sn-devel-104
Diffstat (limited to 'source3/printing')
-rw-r--r--source3/printing/print_cups.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/printing/print_cups.c b/source3/printing/print_cups.c
index 68f367cc51d..561e07d2ac3 100644
--- a/source3/printing/print_cups.c
+++ b/source3/printing/print_cups.c
@@ -1157,7 +1157,7 @@ static int cups_queue_get(const char *sharename,
ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
"attributes-natural-language", NULL, language->language);
- ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
+ ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_KEYWORD,
"requested-attributes",
(sizeof(jattrs) / sizeof(jattrs[0])),
NULL, jattrs);