summaryrefslogtreecommitdiff
path: root/source3/printing/printing.c
diff options
context:
space:
mode:
authorDavid Disseldorp <ddiss@samba.org>2013-09-19 20:31:37 -0700
committerDavid Disseldorp <ddiss@samba.org>2013-11-18 16:03:59 +0100
commit24d025f85d6eea272bff5e1040d4fd2ba0e6b8f3 (patch)
tree7f0f3fd4c70890f28f5f544bbac166baf689acbf /source3/printing/printing.c
parent7e01e4bc64a80ee43f1fe845e0e2eed523f235fa (diff)
downloadsamba-24d025f85d6eea272bff5e1040d4fd2ba0e6b8f3.tar.gz
spoolss: return the spoolss job ID in notifications
Print job notifications currently carry the system print job identifier from the queue structure. Instead, the spoolss job identifier should be resolved and returned. Print clients can use notification job-ids in subsequent spoolss SetJob requests. Returning an incorrect identifier can result in the failure of such requests, e.g. spoolss_SetJob(SPOOLSS_JOB_CONTROL_DELETE). BUG: https://bugzilla.samba.org/show_bug.cgi?id=10271 Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
Diffstat (limited to 'source3/printing/printing.c')
-rw-r--r--source3/printing/printing.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/printing/printing.c b/source3/printing/printing.c
index 43f75e5c438..57d2f0cf714 100644
--- a/source3/printing/printing.c
+++ b/source3/printing/printing.c
@@ -519,7 +519,7 @@ static int unixjob_traverse_fn(TDB_CONTEXT *the_tdb, TDB_DATA key,
return 0;
}
-static uint32 sysjob_to_jobid_pdb(struct tdb_print_db *pdb, int sysjob)
+uint32 sysjob_to_jobid_pdb(struct tdb_print_db *pdb, int sysjob)
{
struct unixjob_traverse_state state;