diff options
| author | Michael Adam <obnox@samba.org> | 2013-12-11 09:34:47 +0100 |
|---|---|---|
| committer | Michael Adam <obnox@samba.org> | 2013-12-11 17:54:22 +0100 |
| commit | 71318d7d685f8e1e112076f84ef2d788acb83547 (patch) | |
| tree | 9b82bb389b316bc90fe7ed599bcbd7c2199b8278 /source3/modules | |
| parent | 5aade722cc56ae0d9388dbc4d061c99ebde05214 (diff) | |
| download | samba-71318d7d685f8e1e112076f84ef2d788acb83547.tar.gz | |
shadow_copy2: revert expensive and unnecessary zero-initialization
I was being overly cautious. This is initialization is not
necessary, since further down in the for-loop, the memory
always gets fully initialized because the insert string is
inserted at various slash positions.
So this talloc_zero_array can be skipped: this an expensive
thing to do in virtually every VFS call.
This essentially reverts commit 249e9b4a34d8959bd94735c1921ecfc24d6a2705.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Diffstat (limited to 'source3/modules')
| -rw-r--r-- | source3/modules/vfs_shadow_copy2.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/modules/vfs_shadow_copy2.c b/source3/modules/vfs_shadow_copy2.c index 8243f6329d0..7f5aeb24e3a 100644 --- a/source3/modules/vfs_shadow_copy2.c +++ b/source3/modules/vfs_shadow_copy2.c @@ -482,7 +482,7 @@ static char *shadow_copy2_convert(TALLOC_CTX *mem_ctx, } insertlen = talloc_get_size(insert)-1; - converted = talloc_zero_array(mem_ctx, char, pathlen + insertlen + 1); + converted = talloc_array(mem_ctx, char, pathlen + insertlen + 1); if (converted == NULL) { goto fail; } |