diff options
| author | Ralph Boehme <slow@samba.org> | 2019-10-31 12:45:44 +0100 |
|---|---|---|
| committer | Andreas Schneider <asn@cryptomilk.org> | 2019-11-07 14:16:41 +0000 |
| commit | 4736623c24503b3ca09c76c9dbb134ef833b2f80 (patch) | |
| tree | 3e7c048663f78bc497ad8080fb1e3e2c5eb57e25 /source3/modules | |
| parent | a591de28659919d2afd7ed55106cded6a0d9ab35 (diff) | |
| download | samba-4736623c24503b3ca09c76c9dbb134ef833b2f80.tar.gz | |
s3: rename talloc_sub_advanced() to talloc_sub_full()
We currently have the following substitution functions:
talloc_sub_basic()
talloc_sub_advanced()
talloc_sub_basic() currently substitutes a subset of talloc_sub_advanced().
We'll need a function X that only substitutes what talloc_sub_advanced()
substitutes *without* what talloc_sub_basic() does.
To get there rename talloc_sub_advanced() to talloc_sub_full(). A subsequent
commit will then bring back talloc_sub_advanced() as described above.
Examples with fictional replacement letters A and B. Currently:
talloc_sub_basic: A
talloc_sub_advanced: AB
New:
talloc_sub_basic: A
talloc_sub_advanced: B
talloc_sub_full: AB
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Diffstat (limited to 'source3/modules')
| -rw-r--r-- | source3/modules/vfs_expand_msdfs.c | 2 | ||||
| -rw-r--r-- | source3/modules/vfs_full_audit.c | 2 | ||||
| -rw-r--r-- | source3/modules/vfs_recycle.c | 2 | ||||
| -rw-r--r-- | source3/modules/vfs_virusfilter_utils.c | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/source3/modules/vfs_expand_msdfs.c b/source3/modules/vfs_expand_msdfs.c index 0923489f265..23ea136620c 100644 --- a/source3/modules/vfs_expand_msdfs.c +++ b/source3/modules/vfs_expand_msdfs.c @@ -154,7 +154,7 @@ static char *expand_msdfs_target(TALLOC_CTX *ctx, return NULL; } - targethost = talloc_sub_advanced(ctx, + targethost = talloc_sub_full(ctx, lp_servicename(talloc_tos(), SNUM(conn)), conn->session_info->unix_info->unix_name, conn->connectpath, diff --git a/source3/modules/vfs_full_audit.c b/source3/modules/vfs_full_audit.c index 8e46f983390..b89996b7a56 100644 --- a/source3/modules/vfs_full_audit.c +++ b/source3/modules/vfs_full_audit.c @@ -484,7 +484,7 @@ static char *audit_prefix(TALLOC_CTX *ctx, connection_struct *conn) if (!prefix) { return NULL; } - result = talloc_sub_advanced(ctx, + result = talloc_sub_full(ctx, lp_servicename(talloc_tos(), SNUM(conn)), conn->session_info->unix_info->unix_name, conn->connectpath, diff --git a/source3/modules/vfs_recycle.c b/source3/modules/vfs_recycle.c index b40544ace31..46a4fcb16bf 100644 --- a/source3/modules/vfs_recycle.c +++ b/source3/modules/vfs_recycle.c @@ -467,7 +467,7 @@ static int recycle_unlink_internal(vfs_handle_struct *handle, bool exist; int rc = -1; - repository = talloc_sub_advanced(NULL, lp_servicename(talloc_tos(), SNUM(conn)), + repository = talloc_sub_full(NULL, lp_servicename(talloc_tos(), SNUM(conn)), conn->session_info->unix_info->unix_name, conn->connectpath, conn->session_info->unix_token->gid, diff --git a/source3/modules/vfs_virusfilter_utils.c b/source3/modules/vfs_virusfilter_utils.c index 5da87ea4a00..480279f90d6 100644 --- a/source3/modules/vfs_virusfilter_utils.c +++ b/source3/modules/vfs_virusfilter_utils.c @@ -35,7 +35,7 @@ char *virusfilter_string_sub( connection_struct *conn, const char *str) { - return talloc_sub_advanced(mem_ctx, + return talloc_sub_full(mem_ctx, lp_servicename(mem_ctx, SNUM(conn)), conn->session_info->unix_info->unix_name, conn->connectpath, |