diff options
| author | Jeremy Allison <jra@samba.org> | 2022-06-16 12:05:19 -0700 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2022-06-17 01:28:29 +0000 |
| commit | 69bb8853f61212074a7095055fb3570660a1cc27 (patch) | |
| tree | 5c151b5e1954b39451042efe78f373e23fca8ae9 /source3/modules/vfs_full_audit.c | |
| parent | ec91a583708c57d0da28da7b70e6366153129c64 (diff) | |
| download | samba-69bb8853f61212074a7095055fb3570660a1cc27.tar.gz | |
s3: VFS: full_audit. Ensure the module doesn't load if an operation name is miss-spelled or otherwise unknown.
Document this new behavior. Remove knownfail.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15098
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'source3/modules/vfs_full_audit.c')
| -rw-r--r-- | source3/modules/vfs_full_audit.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/source3/modules/vfs_full_audit.c b/source3/modules/vfs_full_audit.c index 167f446938b..6d38738ac52 100644 --- a/source3/modules/vfs_full_audit.c +++ b/source3/modules/vfs_full_audit.c @@ -751,9 +751,19 @@ static int smb_full_audit_connect(vfs_handle_struct *handle, pd->success_ops = init_bitmap( pd, lp_parm_string_list(SNUM(handle->conn), "full_audit", "success", none)); + if (pd->success_ops == NULL) { + DBG_ERR("Invalid success operations list. Failing connect\n"); + SMB_VFS_NEXT_DISCONNECT(handle); + return -1; + } pd->failure_ops = init_bitmap( pd, lp_parm_string_list(SNUM(handle->conn), "full_audit", "failure", none)); + if (pd->failure_ops == NULL) { + DBG_ERR("Invalid failure operations list. Failing connect\n"); + SMB_VFS_NEXT_DISCONNECT(handle); + return -1; + } /* Store the private data. */ SMB_VFS_HANDLE_SET_DATA(handle, pd, NULL, |