diff options
| author | Swen Schillig <swen@linux.ibm.com> | 2018-11-21 10:59:31 +0100 |
|---|---|---|
| committer | Ralph Boehme <slow@samba.org> | 2018-11-22 08:22:18 +0100 |
| commit | 02514427dba74325510137655a3788e70e29c82d (patch) | |
| tree | 631c307cc1921e5e18ae378fb44c36ea027885e0 /source3/libads | |
| parent | 88d82b44c326cfb3ab1cf1f7288eada2566ab4bc (diff) | |
| download | samba-02514427dba74325510137655a3788e70e29c82d.tar.gz | |
libads: set proper ads_keytab_flush() return code on error
The return code was left on success when the calls to
ads_get_machine_kvno() or ads_clear_service_principal_names()
failed and the processing had to be aborted.
Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Diffstat (limited to 'source3/libads')
| -rw-r--r-- | source3/libads/kerberos_keytab.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/source3/libads/kerberos_keytab.c b/source3/libads/kerberos_keytab.c index 8eb7b2a7c6b..792dc999e6c 100644 --- a/source3/libads/kerberos_keytab.c +++ b/source3/libads/kerberos_keytab.c @@ -453,6 +453,7 @@ int ads_keytab_flush(ADS_STRUCT *ads) if (kvno == -1) { /* -1 indicates a failure */ DEBUG(1, (__location__ ": Error determining the kvno.\n")); + ret = -1; goto out; } @@ -473,6 +474,7 @@ int ads_keytab_flush(ADS_STRUCT *ads) if (!ADS_ERR_OK(aderr)) { DEBUG(1, (__location__ ": Error while clearing service " "principal listings in LDAP.\n")); + ret = -1; goto out; } |