diff options
| author | Samuel Cabrero <scabrero@suse.de> | 2022-06-13 13:56:10 +0200 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2022-06-27 15:50:30 +0000 |
| commit | d64335eaef5ad690ea923a8e6656b9185a54d9fa (patch) | |
| tree | 4b4ac7870c47207d7db997bb33fef581cf77d268 /source3/lib/netapi | |
| parent | c1ab39163bbaf8ef9c8dc92b1d14c3f6cb56456c (diff) | |
| download | samba-d64335eaef5ad690ea923a8e6656b9185a54d9fa.tar.gz | |
s3:libads: Allocate ads->auth.password under ADS_STRUCT talloc context
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Diffstat (limited to 'source3/lib/netapi')
| -rw-r--r-- | source3/lib/netapi/joindomain.c | 14 |
1 files changed, 11 insertions, 3 deletions
diff --git a/source3/lib/netapi/joindomain.c b/source3/lib/netapi/joindomain.c index 7438e8407be..aa0cefe163e 100644 --- a/source3/lib/netapi/joindomain.c +++ b/source3/lib/netapi/joindomain.c @@ -446,15 +446,23 @@ WERROR NetGetJoinableOUs_l(struct libnetapi_ctx *ctx, } } - SAFE_FREE(ads->auth.password); + TALLOC_FREE(ads->auth.password); if (r->in.password) { - ads->auth.password = SMB_STRDUP(r->in.password); + ads->auth.password = talloc_strdup(ads, r->in.password); + if (ads->auth.password == NULL) { + ret = WERR_NOT_ENOUGH_MEMORY; + goto out; + } } else { const char *password = NULL; libnetapi_get_password(ctx, &password); if (password != NULL) { - ads->auth.password = SMB_STRDUP(password); + ads->auth.password = talloc_strdup(ads, password); + if (ads->auth.password == NULL) { + ret = WERR_NOT_ENOUGH_MEMORY; + goto out; + } } } |