summaryrefslogtreecommitdiff
path: root/source3/client
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2017-09-08 16:20:34 -0700
committerJeremy Allison <jra@samba.org>2017-11-11 08:44:36 +0100
commita0f6ea8dec1ab3d19bc93da12a9b0a1c0ccf6142 (patch)
tree92a89a19b96491ea5f23901644d0b13a6f9bba5c /source3/client
parent37ac8ad4bf3122c369eec6f213bb8a62f8e92884 (diff)
downloadsamba-a0f6ea8dec1ab3d19bc93da12a9b0a1c0ccf6142.tar.gz
libsmbclient: Allow server (NetApp) to return STATUS_INVALID_PARAMETER from an echo.
It does this if we send a session ID of zero. The server still replied. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13007 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Nov 11 08:44:37 CET 2017 on sn-devel-144
Diffstat (limited to 'source3/client')
-rw-r--r--source3/client/client.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/source3/client/client.c b/source3/client/client.c
index 8f449e81311..754907d2e09 100644
--- a/source3/client/client.c
+++ b/source3/client/client.c
@@ -6027,7 +6027,13 @@ static void readline_callback(void)
/* Ping the server to keep the connection alive using SMBecho. */
memset(garbage, 0xf0, sizeof(garbage));
status = cli_echo(cli, 1, data_blob_const(garbage, sizeof(garbage)));
- if (NT_STATUS_IS_OK(status)) {
+ if (NT_STATUS_IS_OK(status) ||
+ NT_STATUS_EQUAL(status, NT_STATUS_INVALID_PARAMETER)) {
+ /*
+ * Even if server returns NT_STATUS_INVALID_PARAMETER
+ * it still responded.
+ * BUG: https://bugzilla.samba.org/show_bug.cgi?id=13007
+ */
return;
}