summaryrefslogtreecommitdiff
path: root/selftest
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2021-03-25 15:46:45 -0700
committerJeremy Allison <jra@samba.org>2021-03-30 20:14:35 +0000
commitff48422e63957dd863fda1ede622450312dcb45a (patch)
tree394e22043c1ea428489419d45a1d66b9df79ea25 /selftest
parentc7762a2bee2573421888b1fab8f3c86ea5348458 (diff)
downloadsamba-ff48422e63957dd863fda1ede622450312dcb45a.tar.gz
s3: smbd: Fix SMB_VFS_FGET_NT_ACL/SMB_VFS_FSET_NT_ACL on stream handles.
As this is done on existing files, we know that fsp->base_fsp != NULL and fsp->base_fsp->fh->fd != -1 (i.e. it's a pathref fd) for stream handles. When getting and setting ACLs on stream handles, use the fsp->base_fsp instead (as Windows does). This not only fixes streams_xattr, but will allow us to later analyze and remove all special casing code for get/set ACLs on streams handles. Remove the knownfail.d/stream-acl file. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Mar 30 20:14:35 UTC 2021 on sn-devel-184
Diffstat (limited to 'selftest')
-rw-r--r--selftest/knownfail.d/stream-acl1
1 files changed, 0 insertions, 1 deletions
diff --git a/selftest/knownfail.d/stream-acl b/selftest/knownfail.d/stream-acl
deleted file mode 100644
index 8537396c40b..00000000000
--- a/selftest/knownfail.d/stream-acl
+++ /dev/null
@@ -1 +0,0 @@
-^samba3.smbtorture_s3.plain.SMB2-STREAM-ACL.smbtorture\(fileserver\)