diff options
| author | Douglas Bagnall <douglas.bagnall@catalyst.net.nz> | 2020-05-15 10:52:45 +1200 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2020-07-02 09:01:41 +0000 |
| commit | cc3a67760cf9faaad3af73b1eed9e2ef85276633 (patch) | |
| tree | d90b5a7325ec352f8d1458b4a0245edaf1753865 /selftest | |
| parent | c3fa8ada43e5383f8dec6cd93cbc21139df704f7 (diff) | |
| download | samba-cc3a67760cf9faaad3af73b1eed9e2ef85276633.tar.gz | |
CVE-2020-10745: ndr/dns-utils: prepare for NBT compatibility
NBT has a funny thing where it sometimes needs to send a trailing dot as
part of the last component, because the string representation is a user
name. In DNS, "example.com", and "example.com." are the same, both
having three components ("example", "com", ""); in NBT, we want to treat
them differently, with the second form having the three components
("example", "com.", "").
This retains the logic of e6e2ec0001fe3c010445e26cc0efddbc1f73416b.
Also DNS compression cannot be turned off for NBT.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14378
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Diffstat (limited to 'selftest')
| -rw-r--r-- | selftest/knownfail.d/dns_packet | 1 | ||||
| -rw-r--r-- | selftest/knownfail.d/ndr_dns_nbt | 2 |
2 files changed, 0 insertions, 3 deletions
diff --git a/selftest/knownfail.d/dns_packet b/selftest/knownfail.d/dns_packet index 0662266f689..e69de29bb2d 100644 --- a/selftest/knownfail.d/dns_packet +++ b/selftest/knownfail.d/dns_packet @@ -1 +0,0 @@ -samba.tests.dns_packet.samba.tests.dns_packet.TestNbtPackets.test_127_very_dotty_components diff --git a/selftest/knownfail.d/ndr_dns_nbt b/selftest/knownfail.d/ndr_dns_nbt deleted file mode 100644 index 603395c8c50..00000000000 --- a/selftest/knownfail.d/ndr_dns_nbt +++ /dev/null @@ -1,2 +0,0 @@ -librpc.ndr.ndr_dns_nbt.test_ndr_nbt_string_all_dots -librpc.ndr.ndr_dns_nbt.test_ndr_nbt_string_half_dots |