diff options
| author | Jeremy Allison <jra@samba.org> | 2018-07-12 12:18:50 -0700 |
|---|---|---|
| committer | David Disseldorp <ddiss@samba.org> | 2018-07-13 14:57:14 +0200 |
| commit | c9656fd2977557ab20ec4e3d87c385a9b2f1bf43 (patch) | |
| tree | 884a2f41695959a532192187d6db5fc2862ebe7d /selftest | |
| parent | 1c8d1cceff852acaca4a0ec0da37b053ed03fe4a (diff) | |
| download | samba-c9656fd2977557ab20ec4e3d87c385a9b2f1bf43.tar.gz | |
s3: libsmbclient: Fix cli_splice() fallback when reading less than a complete file.
We were always asking for SPLICE_BLOCK_SIZE even when the
remaining bytes we wanted were smaller than that. This works
when using cli_splice() on a complete file, as the cli_read()
terminated the read at the right place. We always have the
space to read SPLICE_BLOCK_SIZE bytes so this isn't an overflow.
Found by Bailey Berro <baileyberro@google.com>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13527
Signed-off-by: Bailey Berro <baileyberro@google.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Fri Jul 13 14:57:14 CEST 2018 on sn-devel-144
Diffstat (limited to 'selftest')
| -rw-r--r-- | selftest/knownfail | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/selftest/knownfail b/selftest/knownfail index 6d7d962baf0..21ef797ec0f 100644 --- a/selftest/knownfail +++ b/selftest/knownfail @@ -16,8 +16,6 @@ ^samba3.*rap.sam.*.useradd # Not provided by Samba 3 ^samba3.*rap.sam.*.userdelete # Not provided by Samba 3 ^samba3.libsmbclient.opendir # This requires a workgroup called 'WORKGROUP' and for netbios browse lists to have been registered -^samba3.smbtorture_s3.plain\(fileserver\).CLI_SPLICE -^samba3.smbtorture_s3.plain\(ad_dc_ntvfs\).CLI_SPLICE # see bug 8412 ^samba3.smb2.rename.*.simple_nodelete ^samba3.smb2.rename.*.no_share_delete_no_delete_access |