diff options
| author | Samuel Cabrero <scabrero@samba.org> | 2020-06-26 17:20:32 +0200 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2021-04-07 09:18:30 +0000 |
| commit | aac8be5419fdd5e222263e3558d556c1d1dc4cef (patch) | |
| tree | e4c01cc4911dabed083a848e59f55eff2a4f9ef6 /selftest | |
| parent | f5178ef11e675b07ff49c8f1e0b1e193fc0babb2 (diff) | |
| download | samba-aac8be5419fdd5e222263e3558d556c1d1dc4cef.tar.gz | |
s3: rpc_server: Store new association groups in the id tree
Right now a new association group is created for each connection
assigning the legacy 0x53F0 id, but it is not stored anywhere. When a
second client request to join an association group by its id it is not
found and a new one is created with the same ID.
In practise, it means the association groups are not working even in the
same server process.
This commit stores the created association group in the idtree, but to
make use of it assigns a random id instead of the historical 0x53F0.
The test assoc_group_ok2 was wrongly passing before this change because
the same id 0x53F0 was assigned to all association groups.
Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Diffstat (limited to 'selftest')
| -rw-r--r-- | selftest/knownfail | 4 | ||||
| -rw-r--r-- | selftest/knownfail.d/s3-rpc-assoc-groups | 1 |
2 files changed, 2 insertions, 3 deletions
diff --git a/selftest/knownfail b/selftest/knownfail index f4035a6dec2..0be542c5c1e 100644 --- a/selftest/knownfail +++ b/selftest/knownfail @@ -345,11 +345,11 @@ ^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_no_auth_presentation_ctx_invalid4 ^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_spnego_change_auth_type2 ^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_spnego_change_transfer -# Association groups not implemented yet in s3 server implementation +# Association groups between processes not implemented yet in s3 server implementation +^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_assoc_group_ok2\(ad_member\) ^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_assoc_group_fail1\(ad_member\) ^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_assoc_group_fail2\(ad_member\) ^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_assoc_group_fail3\(ad_member\) -^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_assoc_group_diff1\(ad_member\) ^samba4.rpc.echo.*on.*with.object.echo.doublepointer.*nt4_dc ^samba4.rpc.echo.*on.*with.object.echo.surrounding.*nt4_dc ^samba4.rpc.echo.*on.*with.object.echo.enum.*nt4_dc diff --git a/selftest/knownfail.d/s3-rpc-assoc-groups b/selftest/knownfail.d/s3-rpc-assoc-groups deleted file mode 100644 index 29b1b341561..00000000000 --- a/selftest/knownfail.d/s3-rpc-assoc-groups +++ /dev/null @@ -1 +0,0 @@ -^samba3.rpc.bind.assoc_group_handles_external\(nt4_dc\) |