diff options
| author | Volker Lendecke <vl@samba.org> | 2019-07-30 12:24:53 +0200 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2019-07-31 00:12:34 +0000 |
| commit | 2b590e16bcb4f4e1f1f0bf049a863db38e634beb (patch) | |
| tree | b52cf54426a22c0a6f68c62eaf91b0c2d8a8e663 /selftest | |
| parent | ef582ffcf3a220b73f678d9bce0fd37800f76c54 (diff) | |
| download | samba-2b590e16bcb4f4e1f1f0bf049a863db38e634beb.tar.gz | |
smbd: Fix retry for kernel-oplocked files
This now removed comment describes the bug correctly:
/*
* As this timer event is owned by req, it will
* disappear if req it talloc_freed.
*/
In smb1, "req" disappears once the reply_whatever routine is done. Thus
the timer goes away and we never look at "req" again.
This change moves the valid data (xconn and mid) to
deferred_open_record, and changes the talloc hierarchy such that the
timer is now a child of open_rec, which is a child of the deferred
message.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=14060
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jul 31 00:12:34 UTC 2019 on sn-devel-184
Diffstat (limited to 'selftest')
| -rw-r--r-- | selftest/knownfail | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/selftest/knownfail b/selftest/knownfail index 99772b45c4d..ded80b12259 100644 --- a/selftest/knownfail +++ b/selftest/knownfail @@ -15,7 +15,6 @@ ^samba3.smbtorture_s3.crypt_server # expected to give ACCESS_DENIED as SMB1 encryption isn't used ^samba3.smbtorture_s3.*.LOCK12.*\(fileserver\) ^samba3.smbtorture_s3.*.LOCK12.*\(nt4_dc\) -^samba3.smbtorture_s3.*.OPLOCK5.*\(fileserver\) ^samba3.nbt.dgram.*netlogon2\(nt4_dc\) ^samba3.*rap.sam.*.useradd # Not provided by Samba 3 ^samba3.*rap.sam.*.userdelete # Not provided by Samba 3 |