diff options
| author | Michael Hanselmann <public@hansmi.ch> | 2019-03-27 20:17:08 +0100 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2019-04-03 02:43:07 +0000 |
| commit | 29d7c80ee4d78e1dbdd506770a9cb7b34afa0ed0 (patch) | |
| tree | 4921f9ad6bd67165764c4b45ef58ce5685d63aae /selftest | |
| parent | 4ae2fb2e7403191296f7c74f3098fbe121f0796a (diff) | |
| download | samba-29d7c80ee4d78e1dbdd506770a9cb7b34afa0ed0.tar.gz | |
oLschema2ldif: Resolve multiple parsing bugs
The "oLschema2ldif" program contained multiple bugs triggered by
malformed inputs:
* Iteration beyond list of recognized dsdb syntax OIDs when value wasn't
found (bug 9567)
* NULL pointer dereference when input didn't define a name
* Heap buffer overflows for unterminated token values
Tests are added to reproduce all identified bugs.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=9567
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Then adapted to use ARRAY_SIZE() consistently as suggested by
metze.
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Apr 3 02:43:07 UTC 2019 on sn-devel-144
Diffstat (limited to 'selftest')
| -rw-r--r-- | selftest/tests.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/selftest/tests.py b/selftest/tests.py index 48c275c7793..01afdaea2d0 100644 --- a/selftest/tests.py +++ b/selftest/tests.py @@ -258,3 +258,5 @@ plantestsuite("samba.unittests.ntlm_check", "none", [os.path.join(bindir(), "default/libcli/auth/test_ntlm_check")]) plantestsuite("samba.unittests.test_registry_regfio", "none", [os.path.join(bindir(), "default/source3/test_registry_regfio")]) +plantestsuite("samba.unittests.test_oLschema2ldif", "none", + [os.path.join(bindir(), "default/source4/utils/oLschema2ldif/test_oLschema2ldif")]) |