diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2019-12-20 10:50:09 +1300 |
|---|---|---|
| committer | Ralph Boehme <slow@samba.org> | 2019-12-20 11:33:52 +0000 |
| commit | a85d257c1ec3a4505f2a4fcbec0f7e1f60dbff91 (patch) | |
| tree | 4940c4ea2ef423028f585a6cbb26d570f02097d8 /selftest/knownfail.d | |
| parent | 16557e4480a7502d45186854546d502479be156f (diff) | |
| download | samba-a85d257c1ec3a4505f2a4fcbec0f7e1f60dbff91.tar.gz | |
librpc: Do not access name[-1] trying to push "" into a dnsp_name
This simply matches the behaviour from before e7b1acaddf2ccc7de0301cc67f72187ab450e7b5
when the logic for a trailing . was added. This matches what is added in
the dnsRecord attribute for a name of "." over the dnsserver RPC
management interface and is based on what Windows does for that name
in (eg) an MX record.
No a security bug because we use talloc and so name will be just the
end of the talloc header.
Credit to OSS-Fuzz
Found using the fuzz_ndr_X fuzzer
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Dec 20 11:33:52 UTC 2019 on sn-devel-184
Diffstat (limited to 'selftest/knownfail.d')
| -rw-r--r-- | selftest/knownfail.d/ndrdump-dnsp_name | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/selftest/knownfail.d/ndrdump-dnsp_name b/selftest/knownfail.d/ndrdump-dnsp_name deleted file mode 100644 index c4565998cf2..00000000000 --- a/selftest/knownfail.d/ndrdump-dnsp_name +++ /dev/null @@ -1 +0,0 @@ -^samba.tests.blackbox.ndrdump.samba.tests.blackbox.ndrdump.NdrDumpTests.test_ndrdump_dnsp_DnssrvRpcRecord |