diff options
| author | Joseph Sutton <josephsutton@catalyst.net.nz> | 2023-04-12 09:41:29 +1200 |
|---|---|---|
| committer | Andreas Schneider <asn@cryptomilk.org> | 2023-04-12 13:52:32 +0000 |
| commit | 44d03bf47930e81679feede7a7719feb7aa77c95 (patch) | |
| tree | ef617c7de2a209a0d86383ee21d883832e442c1d /selftest/knownfail.d | |
| parent | 80c548437a7a199c3897246a71df2a2c5348b37a (diff) | |
| download | samba-44d03bf47930e81679feede7a7719feb7aa77c95.tar.gz | |
lib/torture: Don't overwrite test outcomes
If a test fails an assertion, and later calls torture_skip() to skip
part of the test, the TORTURE_SKIP result will overwrite the
TORTURE_FAIL result, and the overall outcome will be successful.
To avoid this, we now arrange possible outcomes in order of priority,
and ensure we always keep the higher priority one.
This reveals some failing tests.
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Diffstat (limited to 'selftest/knownfail.d')
| -rw-r--r-- | selftest/knownfail.d/samba3.rpc.samr | 5 | ||||
| -rw-r--r-- | selftest/knownfail.d/samba4.rpc.netlogon-s3 | 4 | ||||
| -rw-r--r-- | selftest/knownfail.d/samba4.rpc.samr | 2 |
3 files changed, 11 insertions, 0 deletions
diff --git a/selftest/knownfail.d/samba3.rpc.samr b/selftest/knownfail.d/samba3.rpc.samr new file mode 100644 index 00000000000..1bcb89e6421 --- /dev/null +++ b/selftest/knownfail.d/samba3.rpc.samr @@ -0,0 +1,5 @@ +# TestPrivateFunctionsDomain is not implemented. +# QueryDisplayInfo does not return all domain groups on the builtin domain handle. +^samba3.rpc.samr.samr\(nt4_dc\) + +^samba3.rpc.samr.users.samr.users\(nt4_dc\) diff --git a/selftest/knownfail.d/samba4.rpc.netlogon-s3 b/selftest/knownfail.d/samba4.rpc.netlogon-s3 new file mode 100644 index 00000000000..a7d6732d091 --- /dev/null +++ b/selftest/knownfail.d/samba4.rpc.netlogon-s3 @@ -0,0 +1,4 @@ +# ServerAuthenticate2 returns NT_STATUS_DOWNGRADE_DETECTED, but we expect NT_STATUS_OK +^samba4.rpc.netlogon-s3\ with\ .netlogon.SetPassword_with_flags\(ad_dc_default\) +^samba4.rpc.netlogon-s3\ with\ validate.netlogon.SetPassword_with_flags\(ad_dc_default\) +^samba4.rpc.netlogon-s3\ with\ bigendian.netlogon.SetPassword_with_flags\(ad_dc_default\) diff --git a/selftest/knownfail.d/samba4.rpc.samr b/selftest/knownfail.d/samba4.rpc.samr new file mode 100644 index 00000000000..5bb04bdab13 --- /dev/null +++ b/selftest/knownfail.d/samba4.rpc.samr @@ -0,0 +1,2 @@ +^samba4.rpc.samr.users\ on\ ncacn_np\ with\ .samr.users\(ad_dc_slowtests\) +^samba4.rpc.samr.users\ against\ s4member\ server\ with\ local\ creds.samr.users\(s4member\) |