diff options
author | Stefan Metzmacher <metze@samba.org> | 2019-03-11 22:45:46 +0100 |
---|---|---|
committer | Andrew Bartlett <abartlet@samba.org> | 2019-03-14 02:12:19 +0000 |
commit | 07a8326746f0c444eedf3860b178fc29d84e8d16 (patch) | |
tree | f2612454a631fa34181db428f11b31ebda712adc /python/samba/dbchecker.py | |
parent | 3e8a435d27da899d0e3dab7cbc0a1c738067eba3 (diff) | |
download | samba-07a8326746f0c444eedf3860b178fc29d84e8d16.tar.gz |
dbcheck: use DSDB_CONTROL_DBCHECK_FIX_LINK_DN_NAME when renaming deleted objects
We should never do originating updates on deleted objects.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'python/samba/dbchecker.py')
-rw-r--r-- | python/samba/dbchecker.py | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/python/samba/dbchecker.py b/python/samba/dbchecker.py index 705be388827..65f4f1294b0 100644 --- a/python/samba/dbchecker.py +++ b/python/samba/dbchecker.py @@ -880,7 +880,7 @@ newSuperior: %s""" % (str(from_dn), str(to_rdn), str(to_base))) else: self.samdb.transaction_cancel() - def err_wrong_dn(self, obj, new_dn, rdn_attr, rdn_val, name_val): + def err_wrong_dn(self, obj, new_dn, rdn_attr, rdn_val, name_val, controls): '''handle a wrong dn''' new_rdn = ldb.Dn(self.samdb, str(new_dn)) @@ -897,7 +897,7 @@ newSuperior: %s""" % (str(from_dn), str(to_rdn), str(to_base))) self.report("Not renaming %s to %s" % (obj.dn, new_dn)) return - if self.do_rename(obj.dn, new_rdn, new_parent, ["show_recycled:1", "relax:0"], + if self.do_rename(obj.dn, new_rdn, new_parent, controls, "Failed to rename object %s into %s" % (obj.dn, new_dn)): self.report("Renamed %s into %s" % (obj.dn, new_dn)) @@ -2335,9 +2335,11 @@ newSuperior: %s""" % (str(from_dn), str(to_rdn), str(to_base))) if name_val is not None: parent_dn = None + controls = ["show_recycled:1", "relax:0"] if isDeleted: if not (systemFlags & samba.dsdb.SYSTEM_FLAG_DISALLOW_MOVE_ON_DELETE): parent_dn = deleted_objects_dn + controls += ["local_oid:%s:1" % dsdb.DSDB_CONTROL_DBCHECK_FIX_LINK_DN_NAME] if parent_dn is None: parent_dn = obj.dn.parent() expected_dn = ldb.Dn(self.samdb, "RDN=RDN,%s" % (parent_dn)) @@ -2348,7 +2350,8 @@ newSuperior: %s""" % (str(from_dn), str(to_rdn), str(to_base))) if expected_dn != obj.dn: error_count += 1 - self.err_wrong_dn(obj, expected_dn, object_rdn_attr, object_rdn_val, name_val) + self.err_wrong_dn(obj, expected_dn, object_rdn_attr, + object_rdn_val, name_val, controls) elif obj.dn.get_rdn_value() != object_rdn_val: error_count += 1 self.report("ERROR: Not fixing %s=%r on '%s'" % (object_rdn_attr, object_rdn_val, str(obj.dn))) |