summaryrefslogtreecommitdiff
path: root/pidl
diff options
context:
space:
mode:
authorAndrew Bartlett <abartlet@samba.org>2023-03-28 18:31:45 +1300
committerAndrew Bartlett <abartlet@samba.org>2023-03-31 01:48:30 +0000
commitb95117dc56e185c8825752b1129ac704f832ce04 (patch)
tree817be4f26a23f28c05e9f4c7282cdb3f83346dd6 /pidl
parent8c58da347c22eaceb95a3c4009bcdbccfd88fce0 (diff)
downloadsamba-b95117dc56e185c8825752b1129ac704f832ce04.tar.gz
libndr/ndr: Remove unused argument from ndr_push_compression_{start,end}()
Removing the unused arguments avoids thier value being calculated in the PIDL generated code, which can be expensive. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Diffstat (limited to 'pidl')
-rw-r--r--pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm6
1 files changed, 2 insertions, 4 deletions
diff --git a/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm b/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
index 55c3965b7b6..7897f257379 100644
--- a/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
+++ b/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
@@ -510,12 +510,11 @@ sub ParseCompressionPushStart($$$$$)
my ($self,$e,$l,$ndr,$env) = @_;
my $comndr = "$ndr\_compressed";
my $alg = compression_alg($e, $l, $env);
- my $dlen = compression_dlen($e, $l, $env);
$self->pidl("{");
$self->indent;
$self->pidl("struct ndr_push *$comndr;");
- $self->pidl("NDR_CHECK(ndr_push_compression_start($ndr, &$comndr, $alg, $dlen));");
+ $self->pidl("NDR_CHECK(ndr_push_compression_start($ndr, &$comndr, $alg));");
return $comndr;
}
@@ -525,9 +524,8 @@ sub ParseCompressionPushEnd($$$$$)
my ($self,$e,$l,$ndr,$env) = @_;
my $comndr = "$ndr\_compressed";
my $alg = compression_alg($e, $l, $env);
- my $dlen = compression_dlen($e, $l, $env);
- $self->pidl("NDR_CHECK(ndr_push_compression_end($ndr, $comndr, $alg, $dlen));");
+ $self->pidl("NDR_CHECK(ndr_push_compression_end($ndr, $comndr, $alg));");
$self->deindent;
$self->pidl("}");
}