diff options
| author | Ralph Boehme <slow@samba.org> | 2021-03-23 11:40:21 +0100 |
|---|---|---|
| committer | Ralph Boehme <slow@samba.org> | 2021-03-31 11:11:31 +0000 |
| commit | 4c3fb2a5912966a61e7ebdb05eb3231a0e1d6033 (patch) | |
| tree | 3e59df526c579064bd3f7b086dd4b75ea5593638 /pidl | |
| parent | 10d753868e810604d8f60673bbd48f55aaff0797 (diff) | |
| download | samba-4c3fb2a5912966a61e7ebdb05eb3231a0e1d6033.tar.gz | |
pidl: set the per-request memory context in the pidl generator
The talloc memory context referenced by the pipe_struct mem_ctx member is used
as talloc parent for RPC response data by the RPC service implementations.
In Samba versions up to 4.10 all talloc children of p->mem_ctx were freed after
a RPC response was delivered by calling talloc_free_children(p->mem_ctx). Commit
60fa8e255254d38e9443bf96f2c0f31430be6ab8 removed this call which resulted in all
memory allocations on this context not getting released, which can consume
significant memory in long running RPC connections.
Instead of putting the talloc_free_children(p->mem_ctx) back, just use the
mem_ctx argument of the ${pipename}_op_dispatch_internal() function which is a
dcesrv_call_state object created by dcesrv_process_ncacn_packet() and released
by the RPC server when the RPC request processing is finished.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14675
CI: https://gitlab.com/samba-team/samba/-/merge_requests/1861
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Diffstat (limited to 'pidl')
| -rw-r--r-- | pidl/lib/Parse/Pidl/Samba4/NDR/ServerCompat.pm | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/pidl/lib/Parse/Pidl/Samba4/NDR/ServerCompat.pm b/pidl/lib/Parse/Pidl/Samba4/NDR/ServerCompat.pm index 54feea0a9ef..d1368c3dbca 100644 --- a/pidl/lib/Parse/Pidl/Samba4/NDR/ServerCompat.pm +++ b/pidl/lib/Parse/Pidl/Samba4/NDR/ServerCompat.pm @@ -299,6 +299,7 @@ sub boilerplate_iface($) $self->pidl("/* Update pipes struct opnum */"); $self->pidl("p->opnum = opnum;"); $self->pidl("p->dce_call = dce_call;"); + $self->pidl("p->mem_ctx = mem_ctx;"); $self->pidl("/* Update pipes struct session info */"); $self->pidl("pipe_session_info = p->session_info;"); $self->pidl("p->session_info = dce_call->auth_state->session_info;"); @@ -344,6 +345,7 @@ sub boilerplate_iface($) $self->pidl(""); $self->pidl("p->dce_call = NULL;"); + $self->pidl("p->mem_ctx = NULL;"); $self->pidl("/* Restore session info */"); $self->pidl("p->session_info = pipe_session_info;"); $self->pidl("p->auth.auth_type = 0;"); |