diff options
| author | Noel Power <noel.power@suse.com> | 2019-07-08 12:12:59 +0000 |
|---|---|---|
| committer | Gary Lockyer <gary@samba.org> | 2019-07-11 04:08:13 +0000 |
| commit | c19f1c9a3e7fc103754703dff11aa3b63b1edb95 (patch) | |
| tree | bf8b5c59c82ffbc44aca8b07daac21508700e1dd /nsswitch | |
| parent | c80606274fdb1f1736e74e8da26d918bf259922e (diff) | |
| download | samba-c19f1c9a3e7fc103754703dff11aa3b63b1edb95.tar.gz | |
nsswitch/libwbclient: clang Fix Potential leak of memory
Fixes:
nsswitch/libwbclient/wbc_sid.c:848:2: warning: Potential leak of memory pointed to by 'extra_data'
free(extra_data);
^
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Diffstat (limited to 'nsswitch')
| -rw-r--r-- | nsswitch/libwbclient/wbc_sid.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/nsswitch/libwbclient/wbc_sid.c b/nsswitch/libwbclient/wbc_sid.c index cec7b519bfd..aab96cf9188 100644 --- a/nsswitch/libwbclient/wbc_sid.c +++ b/nsswitch/libwbclient/wbc_sid.c @@ -792,12 +792,14 @@ wbcErr wbcCtxGetSidAliases(struct wbcContext *ctx, sid_len = wbcSidToStringBuf(&sids[i], sid_str, sizeof(sid_str)); if (buflen < extra_data_len + sid_len + 2) { + char * tmp_data = NULL; buflen *= 2; - extra_data = (char *)realloc(extra_data, buflen); - if (!extra_data) { + tmp_data = (char *)realloc(extra_data, buflen); + if (!tmp_data) { wbc_status = WBC_ERR_NO_MEMORY; BAIL_ON_WBC_ERROR(wbc_status); } + extra_data = tmp_data; } strncpy(&extra_data[extra_data_len], sid_str, |