diff options
| author | Douglas Bagnall <douglas.bagnall@catalyst.net.nz> | 2019-12-03 11:17:26 +1300 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2019-12-04 05:10:31 +0000 |
| commit | 12cccf3447333dfd4f5e437cd57ca5ec68724fdd (patch) | |
| tree | 4f401bc9e23d56456a5ba71663ae30914c1e47ce /libgpo/pygpo.c | |
| parent | d15a3797c7949140c872e82cc42d4f7301a9bf82 (diff) | |
| download | samba-12cccf3447333dfd4f5e437cd57ca5ec68724fdd.tar.gz | |
pygpo: use correct method flags
The METH_KEYWORDS argument must always be combined with METH_VARARGS.
In Python up to 3.7 this was checked at runtime, and as we had no callers to
get_unix_path() in Python we never noticed. In Python 3.8 it is checked at
import time, and everyone notices even if they aren't directly using GPOs.
Found and reported by Val Kulkov.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14209
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'libgpo/pygpo.c')
| -rw-r--r-- | libgpo/pygpo.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libgpo/pygpo.c b/libgpo/pygpo.c index 581d20e0649..97bbb3ec528 100644 --- a/libgpo/pygpo.c +++ b/libgpo/pygpo.c @@ -118,7 +118,7 @@ out: static PyMethodDef GPO_methods[] = { {"get_unix_path", PY_DISCARD_FUNC_SIG(PyCFunction, py_gpo_get_unix_path), - METH_KEYWORDS, + METH_VARARGS | METH_KEYWORDS, NULL }, {NULL} }; |