diff options
| author | Volker Lendecke <vl@samba.org> | 2018-10-18 05:46:37 +0200 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2018-11-02 20:11:11 +0100 |
| commit | 8b9d36221930a487ca5c51bf2e38ed04de9d50f7 (patch) | |
| tree | a05970dddce35f4dd4b9a58da38c415e72b1f442 /libcli | |
| parent | 831ee63f54959168cf34f12d4590102f40448cc5 (diff) | |
| download | samba-8b9d36221930a487ca5c51bf2e38ed04de9d50f7.tar.gz | |
lib: Add dom_sid_str_buf
This is modeled after server_id_str_buf, which as an API to me is easier to
use: I can rely on the compiler to get the buffer size right.
It is designed to violate README.Coding's "Make use of helper variables", but
as this API is simple enough and the output should never be a surprise at all,
I think that's worth it.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Nov 2 20:11:11 CET 2018 on sn-devel-144
Diffstat (limited to 'libcli')
| -rw-r--r-- | libcli/security/dom_sid.c | 10 | ||||
| -rw-r--r-- | libcli/security/dom_sid.h | 2 |
2 files changed, 12 insertions, 0 deletions
diff --git a/libcli/security/dom_sid.c b/libcli/security/dom_sid.c index d913f2d93fb..97f719f3082 100644 --- a/libcli/security/dom_sid.c +++ b/libcli/security/dom_sid.c @@ -505,3 +505,13 @@ char *dom_sid_string(TALLOC_CTX *mem_ctx, const struct dom_sid *sid) talloc_set_name_const(result, result); return result; } + +char *dom_sid_str_buf(const struct dom_sid *sid, struct dom_sid_buf *dst) +{ + int ret; + ret = dom_sid_string_buf(sid, dst->buf, sizeof(dst->buf)); + if ((ret < 0) || (ret >= sizeof(dst->buf))) { + strlcpy(dst->buf, "(INVALID SID)", sizeof(dst->buf)); + } + return dst->buf; +} diff --git a/libcli/security/dom_sid.h b/libcli/security/dom_sid.h index d9f4b3fc8a6..d132628da9f 100644 --- a/libcli/security/dom_sid.h +++ b/libcli/security/dom_sid.h @@ -102,6 +102,8 @@ bool dom_sid_is_valid_account_domain(const struct dom_sid *sid); int dom_sid_string_buf(const struct dom_sid *sid, char *buf, int buflen); char *dom_sid_string(TALLOC_CTX *mem_ctx, const struct dom_sid *sid); +struct dom_sid_buf { char buf[DOM_SID_STR_BUFLEN]; }; +char *dom_sid_str_buf(const struct dom_sid *sid, struct dom_sid_buf *dst); const char *sid_type_lookup(uint32_t sid_type); const struct security_token *get_system_token(void); |