summaryrefslogtreecommitdiff
path: root/libcli
diff options
context:
space:
mode:
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>2023-03-16 15:44:11 +1300
committerAndrew Bartlett <abartlet@samba.org>2023-04-28 02:15:36 +0000
commit22fe657c8a2626816bdb458afe8dc2f094245822 (patch)
tree5a9bb63b411e82eb78ebd5cb6dd086fd336a8d9b /libcli
parent4f5737cbf2931903216322d68084206280a210ad (diff)
downloadsamba-22fe657c8a2626816bdb458afe8dc2f094245822.tar.gz
libcli/sec/sddl decode: don't ignore random junk.
previously a string could have anything in it, so long as every second character was ':'. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'libcli')
-rw-r--r--libcli/security/sddl.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/libcli/security/sddl.c b/libcli/security/sddl.c
index 508ac3e5666..3b2cdfae17a 100644
--- a/libcli/security/sddl.c
+++ b/libcli/security/sddl.c
@@ -524,6 +524,8 @@ struct security_descriptor *sddl_decode(TALLOC_CTX *mem_ctx, const char *sddl,
sd->group_sid = sddl_decode_sid(sd, &sddl, &state);
if (sd->group_sid == NULL) goto failed;
break;
+ default:
+ goto failed;
}
}