summaryrefslogtreecommitdiff
path: root/libcli/security
diff options
context:
space:
mode:
authorJoseph Sutton <josephsutton@catalyst.net.nz>2023-01-27 07:57:27 +1300
committerAndrew Bartlett <abartlet@samba.org>2023-04-05 02:10:34 +0000
commit6d2d1e7df436dcd2514edf444c904e549cf58f5a (patch)
treea7b62d810b0cd46d953b7e350bc65591cae427e8 /libcli/security
parent5fd0811ffacea0d9e872320842be53cb3f9045c1 (diff)
downloadsamba-6d2d1e7df436dcd2514edf444c904e549cf58f5a.tar.gz
CVE-2023-0614 libcli/security: Make some parameters const
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15270 Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'libcli/security')
-rw-r--r--libcli/security/access_check.c10
-rw-r--r--libcli/security/access_check.h2
2 files changed, 6 insertions, 6 deletions
diff --git a/libcli/security/access_check.c b/libcli/security/access_check.c
index 482ab4ce145..fce8bc30dad 100644
--- a/libcli/security/access_check.c
+++ b/libcli/security/access_check.c
@@ -432,7 +432,7 @@ NTSTATUS se_file_access_check(const struct security_descriptor *sd,
return NT_STATUS_OK;
}
-static const struct GUID *get_ace_object_type(struct security_ace *ace)
+static const struct GUID *get_ace_object_type(const struct security_ace *ace)
{
if (ace->object.object.flags & SEC_ACE_OBJECT_TYPE_PRESENT) {
return &ace->object.object.type.type;
@@ -450,7 +450,7 @@ static const struct GUID *get_ace_object_type(struct security_ace *ace)
* rights to the object/attribute
* @returns NT_STATUS_OK, unless access was denied
*/
-static NTSTATUS check_object_specific_access(struct security_ace *ace,
+static NTSTATUS check_object_specific_access(const struct security_ace *ace,
struct object_tree *tree,
bool *grant_access)
{
@@ -521,7 +521,7 @@ NTSTATUS sec_access_check_ds_implicit_owner(const struct security_descriptor *sd
uint32_t access_desired,
uint32_t *access_granted,
struct object_tree *tree,
- struct dom_sid *replace_sid,
+ const struct dom_sid *replace_sid,
enum implicit_owner_rights implicit_owner_rights)
{
uint32_t i;
@@ -580,8 +580,8 @@ NTSTATUS sec_access_check_ds_implicit_owner(const struct security_descriptor *sd
/* check each ace in turn. */
for (i=0; bits_remaining && i < sd->dacl->num_aces; i++) {
- struct dom_sid *trustee;
- struct security_ace *ace = &sd->dacl->aces[i];
+ const struct dom_sid *trustee;
+ const struct security_ace *ace = &sd->dacl->aces[i];
NTSTATUS status;
bool grant_access = false;
diff --git a/libcli/security/access_check.h b/libcli/security/access_check.h
index e7150914524..7c424b9e05a 100644
--- a/libcli/security/access_check.h
+++ b/libcli/security/access_check.h
@@ -70,7 +70,7 @@ NTSTATUS sec_access_check_ds_implicit_owner(const struct security_descriptor *sd
uint32_t access_desired,
uint32_t *access_granted,
struct object_tree *tree,
- struct dom_sid *replace_sid,
+ const struct dom_sid *replace_sid,
enum implicit_owner_rights implicit_owner_rights);
/* modified access check for the purposes of DS security