summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>2021-03-06 09:57:44 +1300
committerJeremy Allison <jra@samba.org>2021-03-11 21:42:43 +0000
commit46e6f6ef8436df7e083f34556c25f66f65ea1ce5 (patch)
tree874d1fdd022b6f1099341c232503cf033f26c06c /lib
parentf67f95f009a417aca2c636e4a6d17fa87325813e (diff)
downloadsamba-46e6f6ef8436df7e083f34556c25f66f65ea1ce5.tar.gz
ldb: correct comments in attrib_handers val_to_int64
c.f. the identical static function in lib/ldb-samba/ldif_handlers.c Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jeremy Allison <jra@samba.org>
Diffstat (limited to 'lib')
-rw-r--r--lib/ldb/common/attrib_handlers.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/lib/ldb/common/attrib_handlers.c b/lib/ldb/common/attrib_handlers.c
index b5212b73159..11921ca429c 100644
--- a/lib/ldb/common/attrib_handlers.c
+++ b/lib/ldb/common/attrib_handlers.c
@@ -100,7 +100,7 @@ int ldb_handler_fold(struct ldb_context *ldb, void *mem_ctx,
return 0;
}
-/* length limited conversion of a ldb_val to a int32_t */
+/* length limited conversion of a ldb_val to an int64_t */
static int val_to_int64(const struct ldb_val *in, int64_t *v)
{
char *end;
@@ -113,8 +113,6 @@ static int val_to_int64(const struct ldb_val *in, int64_t *v)
strncpy(buf, (char *)in->data, in->length);
buf[in->length] = 0;
- /* We've to use "strtoll" here to have the intended overflows.
- * Otherwise we may get "LONG_MAX" and the conversion is wrong. */
*v = (int64_t) strtoll(buf, &end, 0);
if (*end != 0) {
return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;