summaryrefslogtreecommitdiff
path: root/lib/tdb_wrap
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2015-01-19 12:37:13 +0100
committerMichael Adam <obnox@samba.org>2015-01-19 16:17:27 +0100
commit6f5ed443226b890d7dc76f525cbd1263a2bed8fd (patch)
tree4a553ee19f31ff6e1a88bc265bedfdeac2f696d3 /lib/tdb_wrap
parentc5cb1fb6215ed2f7e783b15efaad45b1ec48ad64 (diff)
downloadsamba-6f5ed443226b890d7dc76f525cbd1263a2bed8fd.tar.gz
tdb_wrap: don't let tdb_wrap_open() segfault with name==NULL
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11032 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Mon Jan 19 16:17:28 CET 2015 on sn-devel-104
Diffstat (limited to 'lib/tdb_wrap')
-rw-r--r--lib/tdb_wrap/tdb_wrap.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/lib/tdb_wrap/tdb_wrap.c b/lib/tdb_wrap/tdb_wrap.c
index e762b334efe..62dce062c7c 100644
--- a/lib/tdb_wrap/tdb_wrap.c
+++ b/lib/tdb_wrap/tdb_wrap.c
@@ -130,10 +130,16 @@ struct tdb_wrap *tdb_wrap_open(TALLOC_CTX *mem_ctx,
struct tdb_wrap *result;
struct tdb_wrap_private *w;
+ if (name == NULL) {
+ errno = EINVAL;
+ return NULL;
+ }
+
/* If they specify a .ntdb extension, but the code hasn't been
* converted, we want to complain. */
- if (name && strends(name, ".ntdb")) {
+ if (strends(name, ".ntdb")) {
DEBUG(2, ("tdb(%s): This code does not yet understand ntdb. Please report.\n", name));
+ errno = EINVAL;
return NULL;
}