diff options
| author | David Mulder <dmulder@suse.com> | 2018-10-24 10:55:02 -0600 |
|---|---|---|
| committer | Volker Lendecke <vl@samba.org> | 2018-10-28 00:35:34 +0200 |
| commit | 5391e21dea3168691cee1e6ef6c5959e46d62d1e (patch) | |
| tree | 7873a580518a5e9fe7290cede984b23c2d5403bc /lib/socket | |
| parent | 94f8a690f66718f14e3bddab40215d1d4ce72cfb (diff) | |
| download | samba-5391e21dea3168691cee1e6ef6c5959e46d62d1e.tar.gz | |
lib:socket: If returning early, set ifaces
Prevents a segfault in load_interfaces() when total interfaces == 1.
Fixes regression caused by da68a1b2f417ec82ea4ed3e7a4d867cef8ca8f93.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13665
Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Ralph Böhme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sun Oct 28 00:35:35 CEST 2018 on sn-devel-144
Diffstat (limited to 'lib/socket')
| -rw-r--r-- | lib/socket/interfaces.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/socket/interfaces.c b/lib/socket/interfaces.c index 168bff501c2..ac26b97c248 100644 --- a/lib/socket/interfaces.c +++ b/lib/socket/interfaces.c @@ -363,12 +363,13 @@ static int iface_comp(struct iface_struct *i1, struct iface_struct *i2) above */ int get_interfaces(TALLOC_CTX *mem_ctx, struct iface_struct **pifaces) { - struct iface_struct *ifaces; + struct iface_struct *ifaces = NULL; int total, i, j; total = _get_interfaces(mem_ctx, &ifaces); /* If we have an error, no interface or just one we can leave */ if (total <= 1) { + *pifaces = ifaces; return total; } |