diff options
| author | Günther Deschner <gd@samba.org> | 2016-03-02 18:32:53 +0100 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2016-03-12 06:24:24 +0100 |
| commit | 2e2f81134c86ef3146781d62d9f561f496b74ee2 (patch) | |
| tree | e14236558e35aab43cac78f30af0b5811cfe6791 /lib/socket | |
| parent | 2ef0eed07e494546ba6720a17f00b40d9bafa8ef (diff) | |
| download | samba-2e2f81134c86ef3146781d62d9f561f496b74ee2.tar.gz | |
lib/socket/interfaces: Fix some uninitialied bytes.
Valgrind reports the following:
==26599== Syscall param ioctl(SIOCETHTOOL) points to uninitialised byte(s)
==26599== at 0x7014707: ioctl (in /usr/lib64/libc-2.22.so)
==26599== by 0x79D1585: query_iface_speed_from_name (interfaces.c:152)
==26599== by 0x79D1BBA: _get_interfaces (interfaces.c:277)
==26599== by 0x79D1E80: get_interfaces (interfaces.c:368)
==26599== by 0x508A7E3: load_interfaces (interface.c:612)
==26599== by 0x150B30: main (net.c:963)
==26599== Address 0xffefff0d8 is on thread 1's stack
==26599== in frame #1, created by query_iface_speed_from_name
(interfaces.c:130)
==26599==
==26599== Syscall param ioctl(SIOCETHTOOL) points to uninitialised byte(s)
==26599== at 0x7014707: ioctl (in /usr/lib64/libc-2.22.so)
==26599== by 0x79D15CC: query_iface_speed_from_name (interfaces.c:164)
==26599== by 0x79D1BBA: _get_interfaces (interfaces.c:277)
==26599== by 0x79D1E80: get_interfaces (interfaces.c:368)
==26599== by 0x508A7E3: load_interfaces (interface.c:612)
==26599== by 0x150B30: main (net.c:963)
==26599== Address 0xffefff0d8 is on thread 1's stack
==26599== in frame #1, created by query_iface_speed_from_name
(interfaces.c:130)
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Diffstat (limited to 'lib/socket')
| -rw-r--r-- | lib/socket/interfaces.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/socket/interfaces.c b/lib/socket/interfaces.c index 2cabf46316b..dacd1180fa7 100644 --- a/lib/socket/interfaces.c +++ b/lib/socket/interfaces.c @@ -145,6 +145,7 @@ static void query_iface_speed_from_name(const char *name, uint64_t *speed) goto done; } + ZERO_STRUCT(ifr); strncpy(ifr.ifr_name, name, IF_NAMESIZE); ifr.ifr_data = (void *)&edata; |